New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop upgrade test support for Ubuntu 18.04 #10442
Merged
JeffreyDallas
merged 1 commit into
release/0.45
from
cherry-pick-workflow-change-release0.45
Dec 12, 2023
Merged
chore: Drop upgrade test support for Ubuntu 18.04 #10442
JeffreyDallas
merged 1 commit into
release/0.45
from
cherry-pick-workflow-change-release0.45
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyDallas
changed the title
chore(ci): drop upgrade test support for Ubuntu 18.04 (#10344)
chore: drop upgrade test support for Ubuntu 18.04 (#10344)
Dec 12, 2023
jeromy-cannon
approved these changes
Dec 12, 2023
Signed-off-by: Nathan Klick <nathan@swirldslabs.com> Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Co-authored-by: Quan Nguyen <quan@swirldslabs.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
JeffreyDallas
force-pushed
the
cherry-pick-workflow-change-release0.45
branch
from
December 12, 2023 19:10
fcdc846
to
ef94c82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.45 #10442 +/- ##
===============================================
Coverage 63.11% 63.12%
Complexity 30699 30699
===============================================
Files 3332 3332
Lines 134010 134010
Branches 13886 13886
===============================================
+ Hits 84580 84588 +8
+ Misses 46084 46078 -6
+ Partials 3346 3344 -2 ☔ View full report in Codecov by Sentry. |
JeffreyDallas
changed the title
chore: drop upgrade test support for Ubuntu 18.04 (#10344)
chore: Drop upgrade test support for Ubuntu 18.04
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Also reenable previously failed upgrade tests after NMT fix
Related issue(s):