feat: use address book to determine node id

[kimbor]

Description:
Change the way that node id is determined at startup.

Related issue(s):

Fixes #10450

[github-actions]

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 22s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit 70fc065.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 0s ⏱️ -57s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit 70fc065. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Crypto) Results

211 tests  ±0   204 ✔️ ±0   17m 7s ⏱️ -2s
  22 suites ±0       7 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit 70fc065. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Smart Contract) Results

398 tests  ±0   366 ✔️ +1   45m 33s ⏱️ +52s
  55 suites ±0     32 💤 ±0 
  55 files   ±0       0 ❌  - 1 

Results for commit 70fc065. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Misc) Results

420 tests  ±0   329 ✔️ ±0   29m 25s ⏱️ +31s
  74 suites ±0     91 💤 ±0 
  74 files   ±0       0 ❌ ±0 

Results for commit 70fc065. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: E2E Test Results

    1 files      1 suites   24m 7s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit 70fc065.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   51m 12s ⏱️ - 3m 57s
118 448 tests +3  118 414 ✔️ +3  34 💤 ±0  0 ❌ ±0 
126 865 runs  +3  126 831 ✔️ +3  34 💤 ±0  0 ❌ ±0 

Results for commit 70fc065. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@50a7d5c). Click here to learn what that means.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #10453   +/-   ##
==========================================
  Coverage           ?   63.05%           
  Complexity         ?    30839           
==========================================
  Files              ?     3363           
  Lines              ?   135445           
  Branches           ?    14093           
==========================================
  Hits               ?    85409           
  Misses             ?    46676           
  Partials           ?     3360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Node: Integration Test Results

278 tests  ±0   278 ✔️ ±0   26m 48s ⏱️ +3s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 70fc065. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

[tinker-michaelj]

This scans to me; but imo is too critical a change to commit without unit test coverage.

[Neeharika-Sompalli]

This scans to me; but imo is too critical a change to commit without unit test coverage.

➕ Agreed.

[nathanklick]

This scans to me; but imo is too critical a change to commit without unit test coverage.

➕ Agreed.

There's a limit to how much we can unit test the main() method, but we can cover the supporting methods. However, each and every HapiTest execution does exert testing of these methods (for at least the happy path).

[netopyr]

LGTM

[tinker-michaelj]

LGTM, tyvm @kimbor !