Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix regression tests failed due to HapiGetAccountInfo #10455

Merged
merged 2 commits into from Dec 13, 2023

Conversation

Neeharika-Sompalli
Copy link
Member

Fixes all places getAccountDetails is used to pay with GENESIS

Fixes #10253
Fixes #10255

Copy link

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   16m 42s ⏱️ +56s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 8e4b31a. ± Comparison against base commit aff5fce.

Copy link

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 31s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 8e4b31a.

Copy link

Node: E2E Test Results

    1 files      1 suites   22m 30s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 8e4b31a.

Copy link

Node: HAPI Test (Misc) Results

420 tests  ±0   320 ✔️ ±0   22m 59s ⏱️ -47s
  74 suites ±0   100 💤 ±0 
  74 files   ±0       0 ±0 

Results for commit 8e4b31a. ± Comparison against base commit aff5fce.

Copy link

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   59m 47s ⏱️ + 9m 36s
118 426 tests ±0  118 392 ✔️ ±0  34 💤 ±0  0 ±0 
126 847 runs  ±0  126 813 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 8e4b31a. ± Comparison against base commit aff5fce.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 10s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 8e4b31a.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f00b68) 63.02% compared to head (8e4b31a) 63.01%.
Report is 11 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10455      +/-   ##
=============================================
- Coverage      63.02%   63.01%   -0.01%     
+ Complexity     30803    30802       -1     
=============================================
  Files           3359     3360       +1     
  Lines         135279   135297      +18     
  Branches       14074    14073       -1     
=============================================
+ Hits           85256    85260       +4     
- Misses         46683    46687       +4     
- Partials        3340     3350      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 21s ⏱️ +7s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 8e4b31a. ± Comparison against base commit aff5fce.

Copy link

Node: HAPI Test (Smart Contract) Results

397 tests   356 ✔️  44m 52s ⏱️
  55 suites    41 💤
  55 files        0

Results for commit 8e4b31a.

@JeffreyDallas JeffreyDallas changed the title Fix regression tests fix: Fix regression tests failed due to HapiGetAccountInfo Dec 13, 2023
@JeffreyDallas
Copy link
Contributor

Comment from Neeha:
Since we are no more returning token relations information from any queries, to not change tests we are using getAccountDetails query which is permissoned (only 2 or 50 can be the payer)

@JeffreyDallas JeffreyDallas merged commit fc45c85 into develop Dec 13, 2023
28 of 38 checks passed
@JeffreyDallas JeffreyDallas deleted the fix-regression-tests branch December 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants