Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the marker EXCEPTION for error level messages #10490

Merged
merged 5 commits into from Dec 14, 2023
Merged

fix: use the marker EXCEPTION for error level messages #10490

merged 5 commits into from Dec 14, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #10488

@cody-littley
Use the marker EXCEPTION for error level messages.
8bc6a27 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.46 milestone Dec 13, 2023
@cody-littley cody-littley self-assigned this Dec 13, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests   204 ✔️  18m 27s ⏱️
  22 suites      7 💤
  22 files        0 ❌

Results for commit d393c93.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 0s ⏱️
  13 suites      0 💤
  13 files        0 ❌

Results for commit d393c93.

♻️ This comment has been updated with latest results.

@cody-littley
Fix build issue.
50f6a31 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed build issues.
de01cee 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   51m 32s ⏱️ - 2m 3s
118 429 tests ±0  118 395 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 850 runs  ±0  126 816 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit d393c93. ± Comparison against base commit 45b455c.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (c7dd6e7) 63.04% compared to head (4f19e65) 63.02%.
Report is 5 commits behind head on develop.

❗ Current head 4f19e65 differs from pull request most recent head d393c93. Consider uploading reports for the commit d393c93 to get more accurate results

Files Patch % Lines
...swirlds/demo/merkle/map/FCMTransactionHandler.java 0.00% 18 Missing ⚠️
...emo/merkle/map/internal/ExpectedFCMFamilyImpl.java 6.25% 15 Missing ⚠️
...wirlds/demo/platform/PlatformTestingToolState.java 0.00% 13 Missing ⚠️
...ction/handler/VirtualMerkleTransactionHandler.java 0.00% 12 Missing ⚠️
...swirlds/demo/platform/PlatformTestingToolMain.java 0.00% 9 Missing ⚠️
...om/swirlds/demo/merkle/map/FCMTransactionPool.java 0.00% 8 Missing ⚠️
...ain/java/com/swirlds/signingtool/FileSignTool.java 0.00% 8 Missing ⚠️
...kle/map/test/lifecycle/SaveExpectedMapHandler.java 0.00% 7 Missing ⚠️
...s/common/stream/internal/SingleStreamIterator.java 0.00% 6 Missing ⚠️
...lds/demo/platform/stream/AccountBalanceExport.java 0.00% 5 Missing ⚠️
... and 33 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop   #10490      +/-   ##
=============================================
- Coverage      63.04%   63.02%   -0.02%     
- Complexity     30809    30814       +5     
=============================================
  Files           3361     3361              
  Lines         135334   135381      +47     
  Branches       14088    14088              
=============================================
+ Hits           85315    85321       +6     
- Misses         46659    46702      +43     
+ Partials        3360     3358       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: HAPI Test (Misc) Results

419 tests   320 ✔️  25m 23s ⏱️
  73 suites    99 💤
  73 files        0 ❌

Results for commit d393c93.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   23m 9s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit d393c93.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 49s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit d393c93.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: Integration Test Results

279 tests   279 ✔️  28m 25s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit d393c93.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

398 tests   360 ✔️  46m 4s ⏱️
  55 suites    38 💤
  55 files        0 ❌

Results for commit d393c93.

♻️ This comment has been updated with latest results.

@cody-littley
Remove spammy PTT log.
4f19e65 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed marker for info message.
d393c93 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley marked this pull request as ready for review December 13, 2023 20:52
@cody-littley cody-littley requested review from a team as code owners December 13, 2023 20:52
edward-swirldslabs
edward-swirldslabs reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@edward-swirldslabs edward-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know this doesn't break any validators that were expecting the marker types that were replaced?

@cody-littley
Copy link
Contributor Author

@edward-swirldslabs

How do we know this doesn't break any validators that were expecting the marker types that were replaced?

Well, I will know if it breaks the abbreviated panel. I intend to monitor test results after this merges, and follow up with any fixes as needed.

@cody-littley cody-littley merged commit 66caf68 into develop Dec 14, 2023
49 checks passed
@cody-littley cody-littley deleted the 10488-exception-marker branch December 14, 2023 14:22
This was referenced Dec 15, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edward-swirldslabs edward-swirldslabs edward-swirldslabs left review comments

@anthony-swirldslabs anthony-swirldslabs anthony-swirldslabs left review comments

@nathanklick nathanklick nathanklick approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 approved these changes

@artemananiev artemananiev artemananiev approved these changes

@alittley alittley alittley approved these changes

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

@tomzhenghedera tomzhenghedera Awaiting requested review from tomzhenghedera tomzhenghedera is a code owner automatically assigned from hashgraph/release-engineering

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov is a code owner automatically assigned from hashgraph/platform-architects

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
v0.46
Development

Successfully merging this pull request may close these issues.

Always log errors with the exception marker
7 participants
@cody-littley @nathanklick @lpetrovic05 @artemananiev @alittley @edward-swirldslabs @anthony-swirldslabs