Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove concurrentEthSpecs() #10517

Merged
merged 1 commit into from Dec 14, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

Description:

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners December 14, 2023 19:10
@Neeharika-Sompalli Neeharika-Sompalli changed the title Remove concurrentEthSpecs() chore: Remove concurrentEthSpecs() Dec 14, 2023
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 3s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 181cd30.

Copy link

Node: HAPI Test (Crypto) Results

211 tests   204 ✔️  17m 58s ⏱️
  22 suites      7 💤
  22 files        0

Results for commit 181cd30.

Copy link

Node: Unit Test Results

    2 291 files      2 291 suites   49m 21s ⏱️
118 427 tests 118 393 ✔️ 34 💤 0
126 848 runs  126 814 ✔️ 34 💤 0

Results for commit 181cd30.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@73edb68). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10517   +/-   ##
==========================================
  Coverage           ?   63.01%           
  Complexity         ?    30810           
==========================================
  Files              ?     3361           
  Lines              ?   135366           
  Branches           ?    14086           
==========================================
  Hits               ?    85307           
  Misses             ?    46703           
  Partials           ?     3356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: E2E Test Results

    1 files      1 suites   22m 46s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 181cd30.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 22s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 181cd30.

Copy link

Node: HAPI Test (Misc) Results

419 tests   321 ✔️  25m 41s ⏱️
  73 suites    98 💤
  73 files        0

Results for commit 181cd30.

Copy link

Node: Integration Test Results

278 tests   278 ✔️  28m 8s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 181cd30.

@tinker-michaelj tinker-michaelj merged commit d932dbf into develop Dec 14, 2023
35 of 40 checks passed
@tinker-michaelj tinker-michaelj deleted the disable-concurrent-eth-specs branch December 14, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants