Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional records of hollow account creation via internal transfer with EthereumTransaction #10539

Conversation

MiroslavGatsanoga
Copy link
Collaborator

@MiroslavGatsanoga MiroslavGatsanoga commented Dec 15, 2023

Description:

Enable fuzzy record matching for LeakyCryptoTestsSuite#lazyCreateViaEthereumCryptoTransfer spec, in order to achieve that:

Related issue(s):

#9423

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga MiroslavGatsanoga added the Limechain Work planned for the LimeChain team label Dec 15, 2023
Copy link

github-actions bot commented Dec 15, 2023

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 7s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit be9ac6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

Node: HAPI Test (Crypto) Results

211 tests   205 ✔️  16m 32s ⏱️
  22 suites      6 💤
  22 files        0

Results for commit be9ac6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   49m 42s ⏱️ - 2m 35s
118 617 tests ±0  118 582 ✔️ ±0  35 💤 ±0  0 ±0 
127 034 runs  ±0  126 999 ✔️ ±0  35 💤 ±0  0 ±0 

Results for commit be9ac6e. ± Comparison against base commit 3c74658.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@3c74658). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10539   +/-   ##
==========================================
  Coverage           ?   62.81%           
  Complexity         ?    30898           
==========================================
  Files              ?     3376           
  Lines              ?   136423           
  Branches           ?    14219           
==========================================
  Hits               ?    85696           
  Misses             ?    47324           
  Partials           ?     3403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 15, 2023

Node: E2E Test Results

    1 files      1 suites   22m 55s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit be9ac6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  26m 27s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit be9ac6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

Node: Integration Test Results

280 tests   280 ✔️  28m 35s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit be9ac6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

Node: HAPI Test (Misc) Results

420 tests   347 ✔️  28m 54s ⏱️
  73 suites    73 💤
  73 files        0

Results for commit be9ac6e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

Node: HAPI Test (Smart Contract) Results

412 tests   399 ✔️  52m 8s ⏱️
  55 suites    13 💤
  55 files        0

Results for commit be9ac6e.

♻️ This comment has been updated with latest results.

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
…sfer

Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Dec 19, 2023
tinker-michaelj and others added 2 commits December 19, 2023 16:21
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @MiroslavGatsanoga !

@tinker-michaelj tinker-michaelj merged commit c7dd6e6 into develop Dec 24, 2023
37 checks passed
@tinker-michaelj tinker-michaelj deleted the 09423-conditional-records-hollow-account-creation-internal-transfer branch December 24, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants