fix: Added asserts for threads in all modifying methods #10584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/merkle/VirtualRootNode.java
Outdated
Show resolved
Hide resolved
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/merkle/VirtualRootNode.java
Outdated
Show resolved
Hide resolved
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/merkle/VirtualRootNode.java
Outdated
Show resolved
Hide resolved
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/merkle/VirtualRootNode.java
Outdated
Show resolved
Hide resolved
OlegMazurov
previously approved these changes
Dec 20, 2023
...swirlds-virtualmap/src/main/java/com/swirlds/virtualmap/internal/merkle/VirtualRootNode.java
Outdated
Show resolved
Hide resolved
anthony-swirldslabs
previously approved these changes
Dec 20, 2023
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10584 +/- ##
==========================================
Coverage 63.04% 63.04%
Complexity 30838 30838
==========================================
Files 3363 3363
Lines 135487 135495 +8
Branches 14096 14104 +8
==========================================
+ Hits 85416 85422 +6
+ Misses 46714 46702 -12
- Partials 3357 3371 +14 ☔ View full report in Codecov by Sentry. |
imalygin
force-pushed
the
10583-vm-thread-assert
branch
from
cc4e84f
to
8085a52
Compare
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
imalygin
dismissed stale reviews from anthony-swirldslabs and OlegMazurov
via
3e12345
anthony-swirldslabs
approved these changes
Dec 20, 2023
OlegMazurov
approved these changes
Dec 20, 2023
imalygin
added a commit
that referenced
this pull request
Dec 21, 2023
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added asserts to make sure that modifying methods of
VirtualMapare never used by different threads at the same time.Related issue(s):
Fixes #10583