Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix submittingNodeStillPaidIfServiceFeesOmitted #10589

Merged
merged 1 commit into from Dec 21, 2023

Conversation

mustafauzunn
Copy link
Collaborator

@mustafauzunn mustafauzunn commented Dec 20, 2023

Description:

fix submittingNodeStillPaidIfServiceFeesOmitted

Related issue(s):

Fixes #10536

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Dec 20, 2023
@mustafauzunn mustafauzunn requested review from a team as code owners December 20, 2023 15:00
@mustafauzunn mustafauzunn self-assigned this Dec 20, 2023
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Node: HAPI Test (Token) Results

189 tests   189 ✔️  16m 12s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 66e649d.

Copy link

Node: HAPI Test (Crypto) Results

211 tests   204 ✔️  17m 37s ⏱️
  22 suites      7 💤
  22 files        0

Results for commit 66e649d.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 42s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 66e649d.

Copy link

github-actions bot commented Dec 20, 2023

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   56m 21s ⏱️ -35s
118 678 tests ±0  118 644 ✔️ ±0  34 💤 ±0  0 ±0 
127 095 runs  ±0  127 061 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 66e649d. ± Comparison against base commit eb3429d.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@ec2c2bd). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10589   +/-   ##
==========================================
  Coverage           ?   63.04%           
  Complexity         ?    30838           
==========================================
  Files              ?     3365           
  Lines              ?   135492           
  Branches           ?    14095           
==========================================
  Hits               ?    85418           
  Misses             ?    46713           
  Partials           ?     3361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: E2E Test Results

    1 files      1 suites   25m 23s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 66e649d.

Copy link

Node: Integration Test Results

280 tests   280 ✔️  28m 21s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 66e649d.

Copy link

Node: HAPI Test (Smart Contract) Results

398 tests   373 ✔️  45m 15s ⏱️
  55 suites    25 💤
  55 files        0

Results for commit 66e649d.

Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Node: HAPI Test (Misc) Results

421 tests  ±0   335 ✔️ +1   28m 38s ⏱️ - 1m 1s
  74 suites ±0     86 💤  - 1 
  74 files   ±0       0 ±0 

Results for commit 66e649d. ± Comparison against base commit eb3429d.

@mustafauzunn mustafauzunn merged commit 1061cc9 into develop Dec 21, 2023
42 checks passed
@mustafauzunn mustafauzunn deleted the 10536-fix-record-creation-suite branch December 21, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix submittingNodeStillPaidIfServiceFeesOmitted
3 participants