feat: Add broken up version of PCES classes #10595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Littley <austin@swirldslabs.com>
alittley
requested review from
lpetrovic05,
cody-littley and
edward-swirldslabs
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10595 +/- ##
==========================================
Coverage ? 62.85%
Complexity ? 30888
==========================================
Files ? 3374
Lines ? 136220
Branches ? 14194
==========================================
Hits ? 85616
Misses ? 47212
Partials ? 3392 ☔ View full report in Codecov by Sentry. |
edward-swirldslabs
previously approved these changes
Dec 20, 2023
...latform-core/src/main/java/com/swirlds/platform/event/preconsensus/EventDurabilityNexus.java
Show resolved
Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/PcesFiles.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Austin Littley <austin@swirldslabs.com>
cody-littley
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreconsensusEventWriterto new framework #10024The new files in this PR are a broken-up rework of the existing PCES files. The new files aren't used yet, and the old files are left alone.
diagram