Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replacing minGenNonAncient data flow with NonAncientEventWindow #10597

Merged
merged 16 commits into from Dec 29, 2023
Merged

chore: replacing minGenNonAncient data flow with NonAncientEventWindow #10597

merged 16 commits into from Dec 29, 2023

Conversation

edward-swirldslabs
Copy link
Contributor

Description:
This PR is part of the Dynamic Address Book Phase 3 refactor at the platform level.
This PR replaces the minGenNonAncient data flow with a wrapping NonAncientEventWindow object.

This is the first step in refactoring away from minGenNonAncient as our ancient threshold. The new NonAncientEventWindow provides the following:

  1. latestConsensusRound - the latest round to come to consensus.
  2. pendingConsensusRound - the current round coming to consensus == 1+latestConsensusRound
  3. minGenNonAncient - this will be deprecated and replaced with a threshold based on round
  4. minRoundNonAncient - the new threshold for determining when events become ancient based on their birth round.

Related issue(s):

Fixes #10579

Notes for reviewer:
New Wiring Diagram

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@edward-swirldslabs
Adding NonAncientEventWindow
f6f6c50 
replaces the `minGenNonAncient` data flow with a wrapping `NonAncientEventWindow`

Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs
fixing diagram command
8c2dbbe 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner December 20, 2023 19:50
@edward-swirldslabs edward-swirldslabs self-assigned this Dec 20, 2023
@edward-swirldslabs edward-swirldslabs added this to the v0.46 milestone Dec 20, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited

Node: HAPI Test (Token) Results

189 tests   189 ✔️  15m 54s ⏱️
  13 suites      0 💤
  13 files        0 ❌

Results for commit 566ba7d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited

Node: HAPI Test (Crypto) Results

211 tests   207 ✔️  17m 36s ⏱️
  22 suites      3 💤
  22 files        1 ❌

For more details on these failures, see this check.

Results for commit 566ba7d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   23m 21s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit 566ba7d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   54m 5s ⏱️ +41s
118 634 tests ±0  118 599 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
127 051 runs  ±0  127 016 ✔️ ±0  35 💤 ±0  0 ❌ ±0 

Results for commit 566ba7d. ± Comparison against base commit 2ee5ce0.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@2ee5ce0). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #10597   +/-   ##
==========================================
  Coverage           ?   62.81%           
  Complexity         ?    30926           
==========================================
  Files              ?     3380           
  Lines              ?   136639           
  Branches           ?    14240           
==========================================
  Hits               ?    85823           
  Misses             ?    47420           
  Partials           ?     3396

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited

Node: HAPI Test (Time Consuming) Results

20 tests   17 ✔️  45m 10s ⏱️
  2 suites    3 💤
  2 files      0 ❌

Results for commit 566ba7d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited

Node: Integration Test Results

293 tests  ±0   293 ✔️ ±0   1h 3m 52s ⏱️ +15s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 566ba7d. ± Comparison against base commit 2ee5ce0.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2023 •
edited

Node: HAPI Test (Smart Contract) Results

411 tests   401 ✔️  51m 25s ⏱️
  55 suites      9 💤
  55 files        1 ❌

For more details on these failures, see this check.

Results for commit 566ba7d.

♻️ This comment has been updated with latest results.

@edward-swirldslabs edward-swirldslabs mentioned this pull request Dec 21, 2023
Open
4 tasks
@edward-swirldslabs @cody-littley
Update platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/p…
3903f37 
…latform/consensus/NonAncientEventWindow.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs
Merge branch 'develop' into 10579-NonAncientEventWindow
6029b8f 
# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/wiring/LinkedEventIntakeWiring.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/wiring/diagram-commands.txt
@edward-swirldslabs
Updating API to use NonAncientEventWindow
a106240 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs requested a review from a team as a code owner December 27, 2023 20:50
@edward-swirldslabs
fixing comment
d411ae2 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2023 •
edited

Node: HAPI Test (Misc) Results

382 tests  +1   323 ✔️ +2   23m 21s ⏱️ -16s
  72 suites ±0     59 💤 ±0 
  72 files   ±0       0 ❌  - 1 

Results for commit 566ba7d. ± Comparison against base commit 2ee5ce0.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
com.hedera.services.bdd.suites.block.BlockSuite ‑ initializationError

com.hedera.services.bdd.suites.block.BlockSuite ‑ blck001And002And003And004ReturnsCorrectBlockProperties
com.hedera.services.bdd.suites.block.BlockSuite ‑ blck003ReturnsTimestampOfTheBlock

♻️ This comment has been updated with latest results.

@edward-swirldslabs
fixing unit test
bec38a4 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
mxtartaglia-sl
mxtartaglia-sl previously approved these changes Dec 28, 2023
View reviewed changes
@edward-swirldslabs
Merge branch 'develop' into 10579-NonAncientEventWindow
58e4672 
# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java
@edward-swirldslabs @cody-littley
Update platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/p…
d52a84e 
…latform/consensus/NonAncientEventWindow.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs @cody-littley
Update platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/p…
89daaa2 
…latform/consensus/NonAncientEventWindow.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs @cody-littley
Update platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/p…
613469a 
…latform/consensus/NonAncientEventWindow.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs @cody-littley
Update platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/p…
3254019 
…latform/consensus/NonAncientEventWindow.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs @cody-littley
Update platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/p…
e97eb03 
…latform/event/creation/tipset/TipsetTracker.java

Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Signed-off-by: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com>
@edward-swirldslabs
Merge branch '10579-NonAncientEventWindow' of github.com:hashgraph/he…
af1ae0d 
…dera-services into 10579-NonAncientEventWindow
@edward-swirldslabs
fixing merge conflict
9d43e8e 
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs merged commit dc495c5 into develop Dec 29, 2023
38 of 42 checks passed
@edward-swirldslabs edward-swirldslabs deleted the 10579-NonAncientEventWindow branch December 29, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@poulok poulok Awaiting requested review from poulok poulok is a code owner automatically assigned from hashgraph/platform-hashgraph

@alittley alittley Awaiting requested review from alittley

@hendrikebbers hendrikebbers Awaiting requested review from hendrikebbers hendrikebbers is a code owner automatically assigned from hashgraph/platform-base

@lpetrovic05 lpetrovic05 Awaiting requested review from lpetrovic05

@mxtartaglia-sl mxtartaglia-sl Awaiting requested review from mxtartaglia-sl

Assignees

@edward-swirldslabs edward-swirldslabs

Labels
None yet
Projects
None yet
Milestone
v0.46
Development

Successfully merging this pull request may close these issues.

Replace minGenNonAncient data flow with NonAncientEventWindow
4 participants
@edward-swirldslabs @lpetrovic05 @cody-littley @mxtartaglia-sl