chore: accommodate unclassifiable statuses in mod-service #10651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dikel <dikelito@tutamail.com>
…from property Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
…ate system contract Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
…unclassifiable-statuses
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10651 +/- ##
=============================================
- Coverage 62.82% 62.81% -0.01%
- Complexity 30913 30915 +2
=============================================
Files 3378 3378
Lines 136483 136493 +10
Branches 14225 14227 +2
=============================================
+ Hits 85741 85743 +2
- Misses 47343 47350 +7
- Partials 3399 3400 +1 ☔ View full report in Codecov by Sentry. |
tinker-michaelj
deleted the
10637-accommodate-unclassifiable-statuses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
classifiableTakesPriorityOverUnclassifiable()#10650Historyif its status is "classifiable" (i.e., notINVALID_PAYER_SIGNATUREorINVALID_NODE_ACCOUNT).hasDuplicate()to returnNO_DUPLICATEwhen the transaction id'sHistoryis either missing or has only unclassifiable records.