Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setting for birth round ancient threshold #10660

Merged
merged 3 commits into from Jan 2, 2024

Conversation

cody-littley
Copy link
Contributor

Closes #10659

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley self-assigned this Dec 28, 2023
@cody-littley cody-littley requested a review from a team as a code owner December 28, 2023 13:56
@cody-littley cody-littley changed the title Add setting for birth round ancient threshold. feat: add setting for birth round ancient threshold Dec 28, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

github-actions bot commented Dec 28, 2023

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 1s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 3c58b9e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 28, 2023

Node: HAPI Test (Crypto) Results

211 tests   208 ✔️  17m 5s ⏱️
  22 suites      3 💤
  22 files        0

Results for commit 3c58b9e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 28, 2023

Node: E2E Test Results

    1 files      1 suites   23m 48s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 3c58b9e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 28, 2023

Node: HAPI Test (Misc) Results

382 tests   323 ✔️  24m 57s ⏱️
  72 suites    59 💤
  72 files        0

Results for commit 3c58b9e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 28, 2023

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   56m 40s ⏱️ + 8m 30s
118 634 tests ±0  118 599 ✔️ ±0  35 💤 ±0  0 ±0 
127 051 runs  ±0  127 016 ✔️ ±0  35 💤 ±0  0 ±0 

Results for commit 3c58b9e. ± Comparison against base commit bf5f821.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (2ee5ce0) 62.82% compared to head (3c58b9e) 62.80%.
Report is 5 commits behind head on develop.

Files Patch % Lines
...ain/java/com/swirlds/platform/SwirldsPlatform.java 0.00% 17 Missing ⚠️
...rlds/platform/consensus/NonAncientEventWindow.java 47.61% 9 Missing and 2 partials ⚠️
...swirlds/platform/components/LinkedEventIntake.java 0.00% 7 Missing ⚠️
...form/event/creation/tipset/TipsetEventCreator.java 0.00% 7 Missing ⚠️
...a/com/swirlds/platform/components/EventIntake.java 0.00% 6 Missing ⚠️
.../platform/event/creation/tipset/TipsetTracker.java 0.00% 5 Missing ⚠️
...va/com/swirlds/platform/wiring/PlatformWiring.java 61.53% 5 Missing ⚠️
...ain/java/com/swirlds/platform/PlatformBuilder.java 0.00% 4 Missing ⚠️
...form/event/creation/AsyncEventCreationManager.java 0.00% 4 Missing ⚠️
...ds/platform/testreader/JrsTestReportGenerator.java 0.00% 4 Missing ⚠️
... and 18 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10660      +/-   ##
=============================================
- Coverage      62.82%   62.80%   -0.02%     
- Complexity     30916    30928      +12     
=============================================
  Files           3379     3380       +1     
  Lines         136590   136640      +50     
  Branches       14238    14240       +2     
=============================================
+ Hits           85806    85822      +16     
- Misses         47390    47424      +34     
  Partials        3394     3394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 28, 2023

Node: HAPI Test (Time Consuming) Results

20 tests   17 ✔️  45m 0s ⏱️
  2 suites    3 💤
  2 files      0

Results for commit 3c58b9e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 28, 2023

Node: Integration Test Results

293 tests  ±0   293 ✔️ ±0   1h 3m 17s ⏱️ +5s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 3c58b9e. ± Comparison against base commit bf5f821.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 28, 2023

Node: HAPI Test (Smart Contract) Results

411 tests   402 ✔️  48m 50s ⏱️
  55 suites      9 💤
  55 files        0

Results for commit 3c58b9e.

♻️ This comment has been updated with latest results.

@cody-littley cody-littley merged commit 0200208 into develop Jan 2, 2024
38 of 39 checks passed
@cody-littley cody-littley deleted the 10659-birth-round-setting branch January 2, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting for birth round ancient threshold
2 participants