Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: state leak #10690

Merged
merged 1 commit into from Jan 2, 2024
Merged

fix: state leak #10690

merged 1 commit into from Jan 2, 2024

Conversation

cody-littley
Copy link
Contributor

Closes #10688

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.46 milestone Dec 29, 2023
@cody-littley cody-littley self-assigned this Dec 29, 2023
@cody-littley cody-littley changed the title Fix state leak. fix: state leak Dec 29, 2023
Copy link

Node: HAPI Test (Crypto) Results

211 tests   208 ✔️  17m 39s ⏱️
  22 suites      3 💤
  22 files        0

Results for commit 0436b09.

Copy link

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 42s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 0436b09.

Copy link

Node: HAPI Test (Misc) Results

382 tests   323 ✔️  22m 39s ⏱️
  72 suites    59 💤
  72 files        0

Results for commit 0436b09.

Copy link

Node: E2E Test Results

    1 files      1 suites   22m 39s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 0436b09.

Copy link

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   52m 36s ⏱️ - 1m 40s
118 635 tests +1  118 600 ✔️ +1  35 💤 ±0  0 ±0 
127 052 runs  +1  127 017 ✔️ +1  35 💤 ±0  0 ±0 

Results for commit 0436b09. ± Comparison against base commit 577dad7.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bf5f821) 62.80% compared to head (0436b09) 62.79%.
Report is 9 commits behind head on develop.

Files Patch % Lines
...m/swirlds/common/merkle/copy/MerkleInitialize.java 0.00% 4 Missing ⚠️
...com/swirlds/platform/state/SwirldStateManager.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10690      +/-   ##
=============================================
- Coverage      62.80%   62.79%   -0.01%     
  Complexity     30925    30925              
=============================================
  Files           3380     3380              
  Lines         136640   136649       +9     
  Branches       14240    14241       +1     
=============================================
- Hits           85814    85810       -4     
- Misses         47430    47448      +18     
+ Partials        3396     3391       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Time Consuming) Results

20 tests   17 ✔️  44m 46s ⏱️
  2 suites    3 💤
  2 files      0

Results for commit 0436b09.

Copy link

Node: HAPI Test (Smart Contract) Results

411 tests   401 ✔️  47m 48s ⏱️
  55 suites      9 💤
  55 files        1

For more details on these failures, see this check.

Results for commit 0436b09.

Copy link

Node: Integration Test Results

293 tests   293 ✔️  1h 4m 0s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 0436b09.

@cody-littley cody-littley merged commit e3434d1 into develop Jan 2, 2024
45 of 50 checks passed
@cody-littley cody-littley deleted the 10688-fix-migration-bug branch January 2, 2024 17:39
cody-littley added a commit that referenced this pull request Jan 2, 2024
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley modified the milestones: v0.46, v0.47 Jan 2, 2024
cody-littley added a commit that referenced this pull request Jan 2, 2024
Signed-off-by: Cody Littley <cody@swirldslabs.com>
poulok pushed a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating root of tree leakes reference count
2 participants