chore: clean up contract call sanity precheck logic

[lukelee-sl]

Description:
Refactor the logic for conditions to precheck for possible invalid contract call transactions

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 25s ⏱️ +3s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Crypto) Results

211 tests  ±0   209 ✔️ ±0   21m 4s ⏱️ -47s
  22 suites ±0       2 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

♻️ This comment has been updated with latest results.

[github-actions]

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 47s ⏱️ + 22m 47s
311 tests +310  311 ✔️ +311  0 💤 ±0  0 ❌  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0 ❌  - 1 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.

EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

[github-actions]

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   53m 28s ⏱️ -45s
118 645 tests +2  118 610 ✔️ +2  35 💤 ±0  0 ❌ ±0 
127 062 runs  +2  127 027 ✔️ +2  35 💤 ±0  0 ❌ ±0 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8aeb2d6) 62.80% compared to head (0b1c8a9) 62.80%.
Report is 1 commits behind head on develop.

Files	Patch %	Lines
...ono/txns/contract/ContractCallTransitionLogic.java	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10750      +/-   ##
=============================================
- Coverage      62.80%   62.80%   -0.01%     
- Complexity     30970    30973       +3     
=============================================
  Files           3384     3384              
  Lines         136851   136856       +5     
  Branches       14267    14268       +1     
=============================================
+ Hits           85947    85950       +3     
- Misses         47490    47497       +7     
+ Partials        3414     3409       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Node: HAPI Test (Misc) Results

422 tests  ±0   404 ✔️ ±0   33m 11s ⏱️ -38s
  73 suites ±0     18 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Time Consuming) Results

22 tests  ±0   17 ✔️ ±0   44m 32s ⏱️ -39s
  2 suites ±0     5 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Smart Contract) Results

411 tests  ±0   411 ✔️ ±0   50m 53s ⏱️ +28s
  55 suites ±0       0 💤 ±0 
  55 files   ±0       0 ❌ ±0 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Integration Test Results

294 tests  ±0   294 ✔️ +1   1h 3m 10s ⏱️ -33s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌  - 1 

Results for commit 0b1c8a9. ± Comparison against base commit 8aeb2d6.

♻️ This comment has been updated with latest results.

[Neeharika-Sompalli]

LGTM ! Thanks @lukelee-sl

[lukelee-sl]

LGTM ! Thanks @lukelee-sl

Thank you for taking a look @Neeharika-Sompalli !

[Neeharika-Sompalli]

LGTM !