fix: fix permissions for upgrade test #10779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
JeffreyDallas
requested review from
dalvizu,
poulok,
netopyr,
Nana-EC,
SimiHunjan,
steven-sheehy,
nickpoorman and
nathanklick
as code owners
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Neeharika-Sompalli
removed request for
nickpoorman,
dalvizu,
rbair23,
netopyr,
povolev15,
steven-sheehy,
SimiHunjan and
Nana-EC
Neeharika-Sompalli
previously approved these changes
Jan 4, 2024
Node: E2E Test Results 1 files ± 0 1 suites ±0 22m 39s ⏱️ + 22m 39s Results for commit d5e7214. ± Comparison against base commit 6fde716. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10779 +/- ##
=============================================
+ Coverage 62.80% 62.86% +0.05%
- Complexity 30970 31010 +40
=============================================
Files 3384 3384
Lines 136851 136817 -34
Branches 14267 14266 -1
=============================================
+ Hits 85947 86005 +58
+ Misses 47490 47373 -117
- Partials 3414 3439 +25 ☔ View full report in Codecov by Sentry. |
Neeharika-Sompalli
approved these changes
Jan 5, 2024
JeffreyDallas
added a commit
that referenced
this pull request
Jan 7, 2024
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Neeharika-Sompalli
added a commit
that referenced
this pull request
Jan 8, 2024
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
JeffreyDallas
added a commit
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
JeffreyDallas
added a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix failed upgrade test