chore: update local node images to Java 21 #10834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isavov
force-pushed
the
10833-docker-images-for-local-node-dont-work
branch
from
35ff637
to
3e0cf50
Compare
isavov
added
Bug
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 11s ⏱️ + 23m 11s Results for commit bb97591. ± Comparison against base commit 688f3d5. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
isavov
requested review from
tomzhenghedera,
dalvizu,
jasperpotts and
povolev15
isavov
force-pushed
the
10833-docker-images-for-local-node-dont-work
branch
from
3e0cf50
to
e0ed1ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10834 +/- ##
==========================================
Coverage 63.26% 63.26%
+ Complexity 31301 31299 -2
==========================================
Files 3390 3390
Lines 137447 137447
Branches 14405 14405
==========================================
+ Hits 86951 86955 +4
+ Misses 46906 46903 -3
+ Partials 3590 3589 -1 ☔ View full report in Codecov by Sentry. |
isavov
force-pushed
the
10833-docker-images-for-local-node-dont-work
branch
3 times, most recently
from
ad423ff
to
c9b8b9e
Compare
isavov
force-pushed
the
10833-docker-images-for-local-node-dont-work
branch
2 times, most recently
from
b2579d0
to
c063cc9
Compare
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
isavov
force-pushed
the
10833-docker-images-for-local-node-dont-work
branch
from
c063cc9
to
bb97591
Compare
This was referenced Jan 15, 2024
nathanklick
pushed a commit
that referenced
this pull request
Jan 16, 2024
#10968) Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> Co-authored-by: Iliya Savov <isavov@users.noreply.github.com>
timo0
pushed a commit
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the
Dockerfilefor local node in order to support Java 21Related issue(s):
Fixes #10833
Notes for reviewer:
Checklist