chore: Cherry pick 9628 #10938

lukelee-sl · 2024-01-12T01:57:11Z

Description:
Cherry pick #9628

Related issue(s):

Fixes #9459

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>

Signed-off-by: nikolay <n.atanasow94@gmail.com>

…lSuite tests Signed-off-by: nikolay <n.atanasow94@gmail.com>

…matching template Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

github-actions · 2024-01-12T02:27:37Z

Node: HAPI Test (Token) Results

189 tests ±0 189 ✔️ ±0 17m 17s ⏱️ -58s
  13 suites ±0     0 💤 ±0
  13 files ±0     0 ❌ ±0

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-12T02:27:41Z

Node: HAPI Test (Crypto) Results

211 tests ±0 208 ✔️ ±0 16m 56s ⏱️ -51s
  22 suites ±0     3 💤 ±0
  22 files ±0     0 ❌ ±0

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-12T02:33:13Z

Node: Unit Test Results

    2 294 files +  1     2 294 suites +1 53m 26s ⏱️ + 6m 42s
118 681 tests +44 118 646 ✔️ +44 35 💤 ±0 0 ❌ ±0
127 098 runs +44 127 063 ✔️ +44 35 💤 ±0 0 ❌ ±0

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

codecov · 2024-01-12T02:34:17Z

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (52b3de7) 62.79% compared to head (d3ab415) 62.79%.

Files	Patch %	Lines
...pp/service/contract/impl/exec/v046/V046Module.java	0.00%	31 Missing ⚠️
...ono/txns/contract/ContractCallTransitionLogic.java	65.21%	3 Missing and 13 partials ⚠️
...no/store/contracts/AbstractLedgerWorldUpdater.java	50.00%	8 Missing and 7 partials ⚠️
...service/contract/impl/state/ProxyWorldUpdater.java	50.00%	4 Missing and 2 partials ⚠️
...no/context/properties/GlobalDynamicProperties.java	42.85%	2 Missing and 2 partials ⚠️
...o/contracts/execution/CallLocalEvmTxProcessor.java	57.14%	1 Missing and 2 partials ⚠️
...contracts/execution/traceability/HederaTracer.java	40.00%	2 Missing and 1 partial ⚠️
...o/contracts/operation/HederaOperationUtilV038.java	62.50%	1 Missing and 2 partials ⚠️
...rvice/contract/impl/exec/TransactionProcessor.java	90.00%	0 Missing and 3 partials ⚠️
...service/contract/impl/exec/utils/FrameBuilder.java	82.35%	0 Missing and 3 partials ⚠️
... and 18 more

Additional details and impacted files

@@                Coverage Diff                 @@
##             release/0.46   #10938      +/-   ##
==================================================
- Coverage           62.79%   62.79%   -0.01%     
- Complexity          30929    31004      +75     
==================================================
  Files                3380     3384       +4     
  Lines              136654   136912     +258     
  Branches            14242    14307      +65     
==================================================
+ Hits                85817    85971     +154     
- Misses              47443    47497      +54     
- Partials             3394     3444      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-12T02:34:22Z

Node: E2E Test Results

    1 files ±    0     1 suites ±0 23m 23s ⏱️ + 23m 23s
311 tests +310 311 ✔️ +311 0 💤 ±0 0 ❌ - 1
333 runs +332 333 ✔️ +333 0 💤 ±0 0 ❌ - 1

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-12T02:36:06Z

Node: HAPI Test (Misc) Results

383 tests +1 323 ✔️ ±0 24m 54s ⏱️ +26s
  72 suites ±0   60 💤 +1
  72 files ±0     0 ❌ ±0

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-12T02:56:22Z

Node: HAPI Test (Time Consuming) Results

20 tests ±0 17 ✔️ ±0 44m 41s ⏱️ -35s
  2 suites ±0   3 💤 ±0
  2 files ±0   0 ❌ ±0

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-12T03:02:48Z

Node: HAPI Test (Smart Contract) Results

444 tests +33 435 ✔️ +34 52m 0s ⏱️ - 3m 23s
  52 suites -   3     9 💤 ±  0
  52 files -   3     0 ❌ -   1

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-12T03:17:15Z

Node: Integration Test Results

    5 files ±  0     5 suites ±0 1h 4m 56s ⏱️ + 1m 5s
312 tests +19 312 ✔️ +20 0 💤 ±0 0 ❌ - 1
314 runs +21 314 ✔️ +22 0 💤 ±0 0 ❌ - 1

Results for commit d3ab415. ± Comparison against base commit 52b3de7.

♻️ This comment has been updated with latest results.

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

stoqnkpL

LGTM! tyvm @lukelee-sl

tinker-michaelj

😓 LGTM, ty @lukelee-sl 🙌

natanasow and others added 30 commits January 11, 2024 16:04

Add basic structure

2fa783d

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Add HederaEvmWorldStateGhostAccount

37caf31

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Remove code cache

4f0804e

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit processors

3795da6

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Add evm v45

bae0a86

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Revert v38 evm changes

4c0714a

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit tests

58f84c8

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Add ff

f529875

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit contracts module

f62707d

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit dagger bindings

4ed52dd

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit opcodes tests

15f79a3

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Handle lazy create to mirror address

881248a

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit erc precompile suite

3bc45d0

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Fix build

bb3b891

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit selfdestruct opcode validation

678e5fe

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit create2operation suite

7f4bdfc

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit ethereum suite

fb4c7f3

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit contract bytecode and info suites

d5ff738

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit tests

15475b4

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit ethereum suite

16b1c87

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit EvmFnResult

1db2e46

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit extcodehash opcode

2e92bd3

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Add basic tests

49d6815

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit evm auto creation logic

56300db

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Add logic to use the evm_address from the ContractID if provided

ea0faa1

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>

Add EET for call to mirror and non-mirror addresses

ef7c9ec

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>

Edit contract call transition logic

e77bcf6

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Edit evm45validationsuite

7351f5e

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Add Evm45ValidationSuite tests

35c3c0a

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Fix build

69fc520

Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech>

natanasow and others added 4 commits January 11, 2024 17:16

chore: update fuzzy-matching templates

99bfe3a

Signed-off-by: nikolay <n.atanasow94@gmail.com>

chore: add NONDETERMINISTIC_TRANSACTION_FEES flag to some ContractCal…

f266b8b

…lSuite tests Signed-off-by: nikolay <n.atanasow94@gmail.com>

chore: resolve conflicts and rebuild ExtCodeHashOperation.json fuzzy-…

79cc2a4

…matching template Signed-off-by: nikolay <n.atanasow94@gmail.com>

chore: cherry pick #9628

ff5cfb2

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

lukelee-sl self-assigned this Jan 12, 2024

lukelee-sl requested review from a team and tinker-michaelj as code owners January 12, 2024 01:57

lukelee-sl requested review from kimbor and acuarica January 12, 2024 01:57

lukelee-sl added 5 commits January 11, 2024 19:29

attempt to stabilize tests

3f7a553

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

fix failing specs

1a38632

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

spotless

161b57e

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

fix failing specs

7f16bd8

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

turn off fuzzy match in spec

d3ab415

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

stoqnkpL approved these changes Jan 12, 2024

View reviewed changes

tinker-michaelj approved these changes Jan 12, 2024

View reviewed changes

Nana-EC approved these changes Jan 12, 2024

View reviewed changes

tinker-michaelj merged commit a0e1585 into release/0.46 Jan 12, 2024
39 checks passed

tinker-michaelj deleted the cherry-pick-9628 branch January 12, 2024 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Cherry pick 9628 #10938

chore: Cherry pick 9628 #10938

lukelee-sl commented Jan 12, 2024

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

codecov bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

stoqnkpL left a comment

tinker-michaelj left a comment

chore: Cherry pick 9628 #10938

chore: Cherry pick 9628 #10938

Conversation

lukelee-sl commented Jan 12, 2024

github-actions bot commented Jan 12, 2024 • edited

Node: HAPI Test (Token) Results

github-actions bot commented Jan 12, 2024 • edited

Node: HAPI Test (Crypto) Results

github-actions bot commented Jan 12, 2024 • edited

Node: Unit Test Results

codecov bot commented Jan 12, 2024 • edited

Codecov Report

github-actions bot commented Jan 12, 2024 • edited

Node: E2E Test Results

github-actions bot commented Jan 12, 2024 • edited

Node: HAPI Test (Misc) Results

github-actions bot commented Jan 12, 2024 • edited

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Jan 12, 2024 • edited

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Jan 12, 2024 • edited

Node: Integration Test Results

stoqnkpL left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

codecov bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited

github-actions bot commented Jan 12, 2024 •

edited