fix: Ensure that the pending creation customizer applies to the address being created

[lukelee-sl]

Description:
Ensure that the pending creation customizer applies to the address being created

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[tinker-michaelj]

LGTM, tyvm @lukelee-sl !

[github-actions]

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   18m 15s ⏱️ -33s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Crypto) Results

211 tests  ±0   208 ✔️ ±0   18m 48s ⏱️ + 1m 47s
  22 suites ±0       3 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Unit Test Results

    2 294 files  ±0      2 294 suites  ±0   51m 6s ⏱️ + 4m 21s
118 681 tests ±0  118 646 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
127 098 runs  ±0  127 063 ✔️ ±0  35 💤 ±0  0 ❌ ±0 

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Misc) Results

383 tests  ±0   323 ✔️ ±0   24m 24s ⏱️ -51s
  72 suites ±0     60 💤 ±0 
  72 files   ±0       0 ❌ ±0 

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a723e9c) 62.79% compared to head (62c491d) 62.79%.

Files	Patch %	Lines
...rvice/mono/ledger/accounts/ContractCustomizer.java	62.50%	3 Missing ⚠️
...no/store/contracts/AbstractLedgerWorldUpdater.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##             release/0.46   #11213   +/-   ##
===============================================
  Coverage           62.79%   62.79%           
- Complexity          31011    31012    +1     
===============================================
  Files                3384     3384           
  Lines              136931   136937    +6     
  Branches            14310    14311    +1     
===============================================
+ Hits                85983    85988    +5     
- Misses              47504    47505    +1     
  Partials             3444     3444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 31s ⏱️ + 22m 31s
311 tests +310  311 ✔️ +311  0 💤 ±0  0 ❌  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0 ❌  - 1 

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Time Consuming) Results

20 tests  ±0   17 ✔️ ±0   45m 7s ⏱️ +38s
  2 suites ±0     3 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Smart Contract) Results

445 tests  +1   435 ✔️ ±0   54m 52s ⏱️ +7s
  52 suites ±0       9 💤 ±0 
  52 files   ±0       1 ❌ +1 

For more details on these failures, see this check.

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Integration Test Results

    5 files  ±0      5 suites  ±0   1h 6m 14s ⏱️ +27s
312 tests ±0  312 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
314 runs  ±0  314 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 62c491d. ± Comparison against base commit a723e9c.

♻️ This comment has been updated with latest results.

[tinker-michaelj]

Awesome, LGTM @lukelee-sl !

[Nana-EC]

Single test failure was the new test added here and only affected modularized code.
The failure will be fixed in develop but if covered by the mono code here. @lukelee-sl to add more details

[lukelee-sl]

There is one failing spec in the HAPI Tests (Smart Contract) check above. It is a spec added by this pr to test the particular issue that this pr looks to address. The test passes in mono service but not in modularized service. Looking deeper, the contract creation fails in modularized service because the address it is trying to call 0x000000000000000000636F6e736F6c652e6c6f67 is not recognized as a valid address and thus the ContractCreate fails. As this pr is addressing an issue in mono service, the failing test is less alarming because the transaction fails. It is an undesirable but not harmful outcome.