Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ui metrics name #11317

Merged
merged 5 commits into from
Feb 2, 2024
Merged

fix: Ui metrics name #11317

merged 5 commits into from
Feb 2, 2024

Conversation

mxtartaglia-sl
Copy link
Contributor

Fixes #11316

Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
Signed-off-by: mxtartaglia <maxi@swirldslabs.com>
@mxtartaglia-sl mxtartaglia-sl self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Node: HAPI Test (Restart) Results

1 tests   0 ✔️  5m 41s ⏱️
1 suites  0 💤
1 files    1

For more details on these failures, see this check.

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✔️  7m 57s ⏱️
1 suites  0 💤
1 files    0

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: E2E Test Results

    1 files      1 suites   26m 57s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: HAPI Test (Token) Results

189 tests   188 ✔️  35m 10s ⏱️
  13 suites      0 💤
  13 files        1

For more details on these failures, see this check.

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: HAPI Test (Crypto) Results

210 tests   209 ✔️  41m 31s ⏱️
  22 suites      0 💤
  22 files        1

For more details on these failures, see this check.

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: Unit Test Results

    2 287 files  ±0      2 287 suites  ±0   5h 9m 15s ⏱️ + 42m 54s
118 586 tests ±0  118 532 ✔️ ±0  54 💤 ±0  0 ±0 
127 093 runs  ±0  127 039 ✔️ ±0  54 💤 ±0  0 ±0 

Results for commit 70fdf1a. ± Comparison against base commit 17ec7af.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (17ec7af) 62.93% compared to head (70fdf1a) 62.93%.

Files Patch % Lines
...om/swirlds/demo/platform/TransactionSubmitter.java 0.00% 3 Missing ⚠️
.../platform/gossip/chatter/protocol/ChatterCore.java 0.00% 2 Missing ⚠️
...om/swirlds/platform/gui/internal/WinTab2Stats.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11317      +/-   ##
=============================================
- Coverage      62.93%   62.93%   -0.01%     
+ Complexity     31075    31072       -3     
=============================================
  Files           3364     3364              
  Lines         137832   137832              
  Branches       14477    14477              
=============================================
- Hits           86750    86745       -5     
- Misses         47387    47397      +10     
+ Partials        3695     3690       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 1, 2024

Node: HAPI Test (Time Consuming) Results

20 tests   20 ✔️  54m 7s ⏱️
  2 suites    0 💤
  2 files      0

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: HAPI Test (Misc) Results

430 tests   414 ✔️  1h 4m 27s ⏱️
  74 suites    14 💤
  74 files        2

For more details on these failures, see this check.

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: Integration Test Results

    5 files      5 suites   1h 6m 17s ⏱️
319 tests 319 ✔️ 0 💤 0
331 runs  331 ✔️ 0 💤 0

Results for commit 70fdf1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 1, 2024

Node: HAPI Test (Smart Contract) Results

451 tests   448 ✔️  1h 39m 47s ⏱️
  52 suites      3 💤
  52 files        0

Results for commit 46a87b1.

@mxtartaglia-sl mxtartaglia-sl merged commit 3aa52f2 into develop Feb 2, 2024
36 of 45 checks passed
@mxtartaglia-sl mxtartaglia-sl deleted the 11316_ui_metrics_name branch February 2, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Metrics consumed by the ui where not changed
3 participants