Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rbs calculation #11514

Closed
wants to merge 4 commits into from
Closed

fix rbs calculation #11514

wants to merge 4 commits into from

Conversation

povolev15
Copy link
Contributor

fix rbs calculation

Related issue(s):

Fixes #11486 - rbs calculation for token fees

mhess-swl and others added 4 commits February 13, 2024 17:31
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
@povolev15 povolev15 self-assigned this Feb 13, 2024
@povolev15 povolev15 requested review from a team as code owners February 13, 2024 22:35
Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  5m 53s ⏱️
2 suites  0 💤
2 files    0

Results for commit 32b19fa.

Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  8m 4s ⏱️
2 suites  0 💤
2 files    0

Results for commit 32b19fa.

Copy link

Node: HAPI Test (Crypto) Results

214 tests   214 ✔️  26m 12s ⏱️
  23 suites      0 💤
  23 files        0

Results for commit 32b19fa.

Copy link

Node: E2E Test Results

    1 files      1 suites   24m 40s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 32b19fa.

Copy link

Node: HAPI Test (Token) Results

187 tests   186 ✔️  23m 23s ⏱️
  14 suites      0 💤
  14 files        1

For more details on these failures, see this check.

Results for commit 32b19fa.

Copy link

Node: HAPI Test (Misc) Results

431 tests   420 ✔️  47m 38s ⏱️
  75 suites    11 💤
  75 files        0

Results for commit 32b19fa.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  54m 47s ⏱️
  3 suites    0 💤
  3 files      0

Results for commit 32b19fa.

Copy link

Node: Unit Test Results

    2 251 files  ±0      2 251 suites  ±0   2h 2m 29s ⏱️ - 52m 8s
110 990 tests +1  110 948 ✔️ +1  42 💤 ±0  0 ±0 
119 377 runs  +1  119 335 ✔️ +1  42 💤 ±0  0 ±0 

Results for commit 32b19fa. ± Comparison against base commit 9902d20.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9902d20) 61.96% compared to head (32b19fa) 61.98%.
Report is 1 commits behind head on develop.

Files Patch % Lines
.../com/hedera/node/app/fees/ChildFeeContextImpl.java 0.00% 1 Missing ⚠️
.../java/com/hedera/node/app/fees/FeeContextImpl.java 66.66% 1 Missing ⚠️
...a/node/app/workflows/handle/HandleContextImpl.java 0.00% 1 Missing ⚠️
...ice/token/impl/handlers/CryptoTransferHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11514      +/-   ##
=============================================
+ Coverage      61.96%   61.98%   +0.02%     
- Complexity     30663    30672       +9     
=============================================
  Files           3376     3376              
  Lines         138145   138128      -17     
  Branches       14503    14499       -4     
=============================================
+ Hits           85597    85623      +26     
+ Misses         48880    48840      -40     
+ Partials        3668     3665       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Smart Contract) Results

456 tests   453 ✔️  1h 8m 21s ⏱️
  53 suites      3 💤
  53 files        0

Results for commit 32b19fa.

@povolev15 povolev15 closed this Feb 14, 2024
@povolev15 povolev15 deleted the 11486-fix-rbs-calculation branch February 14, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay events from round 161949328 and validate record files for differential testing - 5 min
2 participants