New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waive new key's signature when a privileged payer updates a system account #1164
Conversation
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
============================================
- Coverage 87.45% 87.45% -0.01%
Complexity 5277 5277
============================================
Files 436 436
Lines 15608 15607 -1
Branches 1594 1594
============================================
- Hits 13650 13649 -1
Misses 1515 1515
Partials 443 443
Continue to review full report at Codecov.
|
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!! There's one redundant line in HederaSigningOrder
, and I had some suggestions to make the EET spec more clearly target this feature's impact.
Unit test is great, and this will definitely give the desired functional change.
hedera-node/src/main/java/com/hedera/services/sigs/order/HederaSigningOrder.java
Outdated
Show resolved
Hide resolved
test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/MiscCryptoSuite.java
Show resolved
Hide resolved
test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/MiscCryptoSuite.java
Show resolved
Hide resolved
test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/MiscCryptoSuite.java
Show resolved
Hide resolved
test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/MiscCryptoSuite.java
Show resolved
Hide resolved
test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/MiscCryptoSuite.java
Show resolved
Hide resolved
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/CryptoUpdateSuite.java
Outdated
Show resolved
Hide resolved
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: anighanta anirudh.ghanta@hedera.com
Related issue(s):
Closes #1148
Summary of the change:
wave signing with the new key from cryptoUpdate if payer a special account and updating a system account
External impacts:
System administrators will now be able to update the key on a system account without signing the
CryptoUpdate
transaction with the new key.Applicable documentation