Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore token expiry status in TokenDissociate #13106

Merged
merged 2 commits into from
May 7, 2024

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

github-actions bot commented May 7, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  5m 25s ⏱️
2 suites  0 💤
2 files    0

Results for commit 28294f8.

Copy link

github-actions bot commented May 7, 2024

Node: HAPI Test (Token) Results

215 tests   214 ✔️  20m 11s ⏱️
  16 suites      1 💤
  16 files        0

Results for commit 28294f8.

Copy link

github-actions bot commented May 7, 2024

Node: HAPI Test (Crypto) Results

220 tests   220 ✔️  23m 24s ⏱️
  23 suites      0 💤
  23 files        0

Results for commit 28294f8.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, except for a comment. Thanks @tinker-michaelj

Copy link

github-actions bot commented May 7, 2024

Node: HAPI Test (Misc) Results

438 tests   428 ✔️  41m 43s ⏱️
  75 suites    10 💤
  75 files        0

Results for commit 28294f8.

Copy link

github-actions bot commented May 7, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  54m 41s ⏱️
  3 suites    0 💤
  3 files      0

Results for commit 28294f8.

Copy link

github-actions bot commented May 7, 2024

Node: HAPI Test (Smart Contract) Results

507 tests   504 ✔️  1h 3m 45s ⏱️
  56 suites      3 💤
  56 files        0

Results for commit 28294f8.

Copy link

github-actions bot commented May 7, 2024

Node: Unit Test Results

    2 266 files  ±0      2 266 suites  ±0   3h 48m 50s ⏱️ + 39m 19s
112 211 tests  - 2  112 156 ✔️  - 2  55 💤 ±0  0 ±0 
120 673 runs   - 2  120 618 ✔️  - 2  55 💤 ±0  0 ±0 

Results for commit 28294f8. ± Comparison against base commit 8e3ec61.

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tinker-michaelj

@Neeharika-Sompalli Neeharika-Sompalli changed the title fix: ignore token expiry status in TokenDissociate fix: ignore token expiry status in TokenDissociate May 7, 2024
@Neeharika-Sompalli Neeharika-Sompalli merged commit 14b0049 into release/0.49 May 7, 2024
64 of 71 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the cherry-pick-13104 branch May 7, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants