feat: HIP-904 Implement `TokenCancelAirdrop` transaction #14115

stoyanov-st · 2024-07-02T15:24:28Z

Description:

With HIP-904 we introduce Token Airdrops.
We want to provide the option for an airdrop sender to cancel an airdrop that have been sent previously by them. That would be useful if the airdrop sender has made a mistake or the receiver hasn't claimed the airdrop for too long. This would be a way to remove ongoing fees for auto renewal that would be charged from the airdrop sender account.

Related issue(s):
#13683

Fixes #

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

…rdrop' into 013683-implement-token-cancel-airdrop

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

…ients` (#14053) Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Co-authored-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

…enAirdropTransaction' into 013683-implement-token-cancel-airdrop # Conflicts: # hapi/build.gradle.kts # hedera-node/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/CommonPbjConverters.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionHandlers.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleWorkflowModule.java # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java # hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenHandlers.java # hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/TokenHandlersTest.java

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

stoyanov-st · 2024-07-03T14:51:27Z

gradle/plugins/src/main/kotlin/com/hedera/gradle/tasks/GitClone.kt

@@ -59,7 +59,7 @@ abstract class GitClone : DefaultTask() {
                    commandLine(
                        "git",
                        "clone",
-                        "https://github.com/hashgraph/hedera-protobufs.git",
+                        "https://github.com/LimeChain/hedera-protobufs.git",


We will change this when hashgraph/hedera-protobufs#387 is merged

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

github-actions · 2024-07-03T16:39:40Z

Node: HAPI Test (Node Death Reconnect) Results

3 tests 3 ✅ 5m 40s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 0110ff0.

github-actions · 2024-07-03T16:40:02Z

Node: HAPI Test (Token) Results

20 files 20 suites 6m 8s ⏱️
266 tests 264 ✅ 0 💤 2 ❌
341 runs 339 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 0110ff0.

github-actions · 2024-07-03T16:40:36Z

Node: HAPI Test (Restart) Results

3 tests 3 ✅ 6m 38s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 0110ff0.

github-actions · 2024-07-03T16:47:37Z

Node: HAPI Test (Crypto) Results

25 files 25 suites 13m 4s ⏱️
376 tests 375 ✅ 0 💤 1 ❌
384 runs 383 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 0110ff0.

github-actions · 2024-07-03T16:55:01Z

Node: HAPI Test (Misc) Results

51 files 51 suites 20m 32s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
375 runs 375 ✅ 0 💤 0 ❌

Results for commit 0110ff0.

github-actions · 2024-07-03T16:57:19Z

Node: HAPI Test (Time Consuming) Results

19 tests 19 ✅ 23m 1s ⏱️
4 suites 0 💤
4 files 0 ❌

Results for commit 0110ff0.

github-actions · 2024-07-03T16:59:39Z

Node: HAPI Test (Smart Contract) Results

73 files 73 suites 23m 56s ⏱️
623 tests 617 ✅ 0 💤 6 ❌
677 runs 671 ✅ 0 💤 6 ❌

For more details on these failures, see this check.

Results for commit 0110ff0.

github-actions · 2024-07-03T17:28:20Z

Node: Unit Test Results

1 548 files 1 548 suites 2h 33m 57s ⏱️
116 645 tests 116 584 ✅ 59 💤 2 ❌
124 972 runs 124 911 ✅ 59 💤 2 ❌

For more details on these failures, see this check.

Results for commit 0110ff0.

…ncelAirdropHandler (#14091) Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Co-authored-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

…o 013683-implement-token-cancel-airdrop # Conflicts: # hapi/build.gradle.kts # hedera-node/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/CommonPbjConverters.java # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenHandlers.java

…o 013683-implement-token-cancel-airdrop

Neeharika-Sompalli · 2024-07-15T20:11:31Z

...src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenCancelAirdropHandler.java

+        final var key = senderAccount.key();
+        if (key == null || !isValid(key)) {
+            throw new PreCheckException(ACCOUNT_IS_IMMUTABLE);
+        }


This will fail when we do requireKey. We don't need extra check here

Fixed in #14379

Neeharika-Sompalli · 2024-07-15T20:12:52Z

...src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenCancelAirdropHandler.java

+
+        validateFalsePreCheck(op.pendingAirdrops().isEmpty(), EMPTY_PENDING_AIRDROP_ID_LIST);
+        validateFalsePreCheck(
+                op.pendingAirdrops().size() > MAX_ALLOWED_PENDING_AIRDROPS_TO_CANCEL, MAX_PENDING_AIRDROP_ID_EXCEEDED);


Can this be MAX_PENDING_AIRDROPS_EXCEEDED

Now the cancel is separated from the airdrop and we don't have the MAX_PENDING_AIRDROPS_EXCEEDED constant.

vtronkov · 2024-07-24T10:28:15Z

Created a new PR branched from develop - #14379

MrValioBg and others added 7 commits June 25, 2024 17:00

init: setup for TokenCancelAirdrop

bfebbac

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

init: setup for TokenCancelAirdrop

7a69cbc

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

Merge remote-tracking branch 'origin/013683-implement-token-cancel-ai…

2cd52a5

…rdrop' into 013683-implement-token-cancel-airdrop

fix: inject with dagger

3880c50

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

fix: compile error

1efb5fc

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

feat: HIP-904: Add TokenCancelAirdrop transaction verb for `test-cl…

077495f

…ients` (#14053) Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Co-authored-by: Mustafa Uzun <mustafa.uzun@limechain.tech>

chore: add new protobuf statuses

f7d37b1

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

stoyanov-st added the Limechain Work planned for the LimeChain team label Jul 2, 2024

stoyanov-st added this to the v0.53 milestone Jul 2, 2024

stoyanov-st changed the base branch from develop to 13658-implement-tokenAirdropTransaction July 2, 2024 15:27

stoyanov-st added 4 commits July 3, 2024 16:38

chore: spotless

3d5f62f

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

chore: register response code

ed652b3

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

nit: change protobuf repo

bd48d0c

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

stoyanov-st commented Jul 3, 2024

View reviewed changes

stoyanov-st added 3 commits July 3, 2024 18:30

nit: javadoc adjustments

a1e33a7

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

chore: add module info

6a0b517

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

chore: spotless

0110ff0

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

MrValioBg and others added 3 commits July 5, 2024 10:56

Merge branch 'refs/heads/13658-implement-tokenAirdropTransaction' int…

33d0d53

…o 013683-implement-token-cancel-airdrop

Neeharika-Sompalli reviewed Jul 15, 2024

View reviewed changes

vtronkov closed this Jul 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: HIP-904 Implement `TokenCancelAirdrop` transaction #14115

feat: HIP-904 Implement `TokenCancelAirdrop` transaction #14115

stoyanov-st commented Jul 2, 2024

stoyanov-st Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

Neeharika-Sompalli Jul 15, 2024

vtronkov Jul 24, 2024

Neeharika-Sompalli Jul 15, 2024

vtronkov Jul 24, 2024

vtronkov commented Jul 24, 2024

feat: HIP-904 Implement TokenCancelAirdrop transaction #14115

feat: HIP-904 Implement TokenCancelAirdrop transaction #14115

Conversation

stoyanov-st commented Jul 2, 2024

stoyanov-st Jul 3, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 3, 2024

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Jul 3, 2024

Node: HAPI Test (Token) Results

github-actions bot commented Jul 3, 2024

Node: HAPI Test (Restart) Results

github-actions bot commented Jul 3, 2024

Node: HAPI Test (Crypto) Results

github-actions bot commented Jul 3, 2024

Node: HAPI Test (Misc) Results

github-actions bot commented Jul 3, 2024

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Jul 3, 2024

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Jul 3, 2024

Node: Unit Test Results

Neeharika-Sompalli Jul 15, 2024

Choose a reason for hiding this comment

vtronkov Jul 24, 2024

Choose a reason for hiding this comment

Neeharika-Sompalli Jul 15, 2024

Choose a reason for hiding this comment

vtronkov Jul 24, 2024

Choose a reason for hiding this comment

vtronkov commented Jul 24, 2024

feat: HIP-904 Implement `TokenCancelAirdrop` transaction #14115

feat: HIP-904 Implement `TokenCancelAirdrop` transaction #14115