Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: align max lifetime with max auto-renew period #14133

Closed
wants to merge 7 commits into from
Closed

chore: align max lifetime with max auto-renew period #14133

wants to merge 7 commits into from

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Jul 3, 2024 •
edited
Loading

Description:

  • Per title; also fixes test expectations for the new config.

@tinker-michaelj
Align max lifetime with max auto-renew period
9ec600e 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners July 3, 2024 18:36
@tinker-michaelj tinker-michaelj added this to the v0.53 milestone Jul 3, 2024
@tinker-michaelj tinker-michaelj self-assigned this Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: Unit Test Results

  1 545 files    1 545 suites   3h 32m 5s ⏱️
115 799 tests 115 740 ✅ 59 💤 0 ❌
124 114 runs  124 055 ✅ 59 💤 0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 11s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

 22 files   22 suites   5m 46s ⏱️
273 tests 273 ✅ 0 💤 0 ❌
351 runs  351 ✅ 0 💤 0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

3 tests   3 ✅  2m 54s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 50s ⏱️
364 tests 364 ✅ 0 💤 0 ❌
371 runs  371 ✅ 0 💤 0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  23m 29s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

 74 files   74 suites   23m 47s ⏱️
627 tests 627 ✅ 0 💤 0 ❌
684 runs  684 ✅ 0 💤 0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 56s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
375 runs  375 ✅ 0 💤 0 ❌

Results for commit 20695af.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes Jul 4, 2024
View reviewed changes
@tinker-michaelj
Fix old test expectations
dc2aac2 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested a review from a team as a code owner July 4, 2024 23:17
@tinker-michaelj
Merge remote-tracking branch 'origin/develop' into change-default-lif…
d666c5f 
…etime
@tinker-michaelj
spotless
e41882b 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Try again to stabilize CI
fff67cf 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Stabilize remaining specs
20695af 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Merge upstream
160be0f 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested a review from a team as a code owner July 9, 2024 19:52
Neeharika-Sompalli
Neeharika-Sompalli approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj

@tinker-michaelj
Copy link
Collaborator Author

Merged to develop via #14163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

@jasperpotts jasperpotts Awaiting requested review from jasperpotts jasperpotts is a code owner automatically assigned from hashgraph/hedera-base

@iwsimon iwsimon Awaiting requested review from iwsimon iwsimon is a code owner automatically assigned from hashgraph/hedera-services

@stoyanov-st stoyanov-st Awaiting requested review from stoyanov-st stoyanov-st was automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@tinker-michaelj tinker-michaelj

Labels
None yet
Projects
Services Team
Status: ✅ Done
Milestone
v0.53
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tinker-michaelj @Neeharika-Sompalli @Nana-EC