Add fuzz tests for hollow account completion #4855
Merged
+630
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoyan-lime
changed the title
stoqnkpL
reviewed
Feb 15, 2023
There was a problem hiding this comment.
Some ideas:
- a very short expiration time
- throw in some deletions
- having a small enough inventory of keys so we end-up reusing the keys for the operations
- in the future (maybe not this PR), having accounts finalized not from the payer signature only (when we update the implementation for this)
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
stoyan-lime
force-pushed
the
04633-add-fuzzing-tests-for-hollow-account-completion-transactions
branch
from
cbac879
to
43d3e2a
Compare
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
…t-completion-transactions
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
Signed-off-by: Stoyan Stoyanov <stoyan.stoyanov@limechain.tech>
stoyan-lime
changed the title
stoyan-lime
requested review from
tinker-michaelj,
stoqnkpL and
Neeharika-Sompalli
…t-completion-transactions
…t-completion-transactions
…t-completion-transactions
…t-completion-transactions
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4855 +/- ##
==============================================
+ Coverage 0 91.09% +91.09%
- Complexity 0 16898 +16898
==============================================
Files 0 1279 +1279
Lines 0 48476 +48476
Branches 0 4890 +4890
==============================================
+ Hits 0 44159 +44159
- Misses 0 3390 +3390
- Partials 0 927 +927 ☔ View full report in Codecov by Sentry. |
…t-completion-transactions
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
...java/com/hedera/services/bdd/spec/infrastructure/providers/ops/BiasedDelegatingProvider.java
Show resolved
Hide resolved
...va/com/hedera/services/bdd/spec/infrastructure/providers/ops/hollow/RandomHollowAccount.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
previously approved these changes
May 2, 2023
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
|
Kudos, SonarCloud Quality Gate passed!
|
Thanks @tinker-michaelj, pushed some updates regarding the comments. |
tinker-michaelj
approved these changes
May 4, 2023
MiroslavGatsanoga
approved these changes
May 5, 2023
MiroslavGatsanoga
deleted the
04633-add-fuzzing-tests-for-hollow-account-completion-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stoyan Stoyanov stoyan.stoyanov@limechain.tech
Description:
Testing of hollow account completion by fuzzing different operations.
The test randomly runs the following operations (with bias defined in properties file):
Note: When creating an account it is saved in both the key and account registry and to differentiate between SECP256K1 keys and account keys, but still easily get one from the other we create hollow account names by adding "#" to the key name that created it.
Related issue(s):
Fixes #4633