Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FileSignTool #4988

Merged
merged 9 commits into from Feb 15, 2023
Merged

Update FileSignTool #4988

merged 9 commits into from Feb 15, 2023

Conversation

JeffreyDallas
Copy link
Contributor

Adding more logging to show the signing process

Part of regression repo PR
https://github.com/swirlds/swirlds-platform-regression/pull/3189

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

Unit Test Results

  1 208 files    1 208 suites   34m 6s ⏱️
96 572 tests 96 571 ✔️ 1 💤 0
98 198 runs  98 197 ✔️ 1 💤 0

Results for commit 3e8a394.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

Integration Test Results

104 tests   104 ✔️  10m 2s ⏱️
    2 suites      0 💤
    2 files        0

Results for commit 3e8a394.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

E2E Test Results

    1 files      1 suites   17m 27s ⏱️
308 tests 308 ✔️ 0 💤 0
326 runs  326 ✔️ 0 💤 0

Results for commit 3e8a394.

♻️ This comment has been updated with latest results.

Signed-off-by: Quan Nguyen <quan.nguyen@swirldslabs.com>
qnswirlds
qnswirlds previously approved these changes Feb 15, 2023
Copy link
Contributor

@qnswirlds qnswirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typos and wordings.

jeromy-cannon
jeromy-cannon previously approved these changes Feb 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JeffreyDallas JeffreyDallas merged commit 1636335 into develop Feb 15, 2023
@JeffreyDallas JeffreyDallas deleted the 03188-D-update-filesigntool-log branch February 15, 2023 20:35
@nickpoorman nickpoorman added this to the v0.36.0 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants