Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

05786 5396 misc startup improvements #5790

Merged
merged 65 commits into from Apr 5, 2023
Merged

05786 5396 misc startup improvements #5790

merged 65 commits into from Apr 5, 2023

Conversation

cody-littley
Copy link
Contributor

Various minor cleanups related to the platform startup sequence.

Closes #5786
Must be merged after #5396

@cody-littley
Integrate preconsensus event stream (except for removal of old files.…
9e2cf3f 
….. that still needs to be done)

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Initial work for state metadata file.
6d6f70e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
56f5f46 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added TODO.
5ecfeda 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
incremental work
4003ef4 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Integrate writing of metadata file. Lots of loose ends need tying.
3dd786e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
602f77b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental improvements.
29bfeba 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Add unit test
d240531 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental improvements.
c03e66b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Add minimum generation non-ancient explicitly to state.
8d0a30e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix naming.
8efdb0c 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Check minimum generation non-ancient in unit test.
1400c78 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Revert settings change.
9bc6a28 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Removed code that is in a different PR.
f668a47 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Cleanup.
6b26fe1 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 05631-state-metadata-file
9bac432 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed smells.
e53fb30 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed broken tests.
4ae4138 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 05396-write-to-preconsensus-stream-2
2db33e4 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch '05631-state-metadata-file' into 05396-write-to-preconse…
0e139f1 
…nsus-stream-2

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added cleanup of old files.
50cfde2 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added ability to disable preconsensus stream.
444696b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix bugs.
5d21d90 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Qualify event files with node ID (to prevent collisions when testing …
ae65eb0 
…locally)

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 05396-write-to-preconsensus-stream-2
e376373 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
c115f64 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added TODO
edac2af 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Added new unit tests.
fecb285 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
final, spotless
5498982 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley requested review from a team as code owners March 30, 2023 20:12
@cody-littley
Merge branch 'develop' into 05786-5396-misc-startup-improvements
c244baa 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: +94.31 🎉

Comparison is base (4bc8951) 0.00% compared to head (c244baa) 94.31%.

❗ Current head c244baa differs from pull request most recent head 63de082. Consider uploading reports for the commit 63de082 to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #5790       +/-   ##
==============================================
+ Coverage           0   94.31%   +94.31%     
- Complexity         0    17039    +17039     
==============================================
  Files              0     1269     +1269     
  Lines              0    46999    +46999     
  Branches           0     4822     +4822     
==============================================
+ Hits               0    44328    +44328     
- Misses             0     1772     +1772     
- Partials           0      899      +899

see 1269 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

alittley
alittley previously approved these changes Mar 31, 2023
View reviewed changes
@cody-littley
Merge branch 'develop' into 05786-5396-misc-startup-improvements
77f1028 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
63de082 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023 •
edited

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cody-littley cody-littley merged commit f2bd71f into develop Apr 5, 2023
14 of 16 checks passed
@cody-littley cody-littley deleted the 05786-5396-misc-startup-improvements branch April 5, 2023 17:50
@nickpoorman nickpoorman added this to the v0.38.0 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikebbers hendrikebbers hendrikebbers approved these changes

@lpetrovic05 lpetrovic05 lpetrovic05 approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas JeffreyDallas was automatically assigned from hashgraph/release-engineering

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick was automatically assigned from hashgraph/release-engineering-managers

@netopyr netopyr Awaiting requested review from netopyr netopyr is a code owner automatically assigned from hashgraph/platform-base

@imalygin imalygin Awaiting requested review from imalygin imalygin was automatically assigned from hashgraph/platform-data

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov was automatically assigned from hashgraph/platform-architects

@alittley alittley Awaiting requested review from alittley

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
v0.38
Development

Successfully merging this pull request may close these issues.

Misc startup sequence cleanup
6 participants
@cody-littley @hendrikebbers @lpetrovic05 @alittley @edward-swirldslabs @nickpoorman