Assert EVM is set correctly in contract create #5797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vasil Vasilev <vasil.yanev15@gmail.com>
Signed-off-by: Vasil Vasilev <vasil.yanev15@gmail.com>
randered
commented
Mar 27, 2023
...clients/src/main/java/com/hedera/services/bdd/spec/queries/contract/HapiGetContractInfo.java
Show resolved
Hide resolved
Signed-off-by: Vasil Vasilev <vasil.yanev15@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #5797 +/- ##
==============================================
+ Coverage 0 91.37% +91.37%
- Complexity 0 16963 +16963
==============================================
Files 0 1270 +1270
Lines 0 48486 +48486
Branches 0 4840 +4840
==============================================
+ Hits 0 44304 +44304
- Misses 0 3259 +3259
- Partials 0 923 +923 see 1270 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dimitar-dinev
approved these changes
Mar 31, 2023
MiroslavGatsanoga
approved these changes
Mar 31, 2023
mustafauzunn
requested review from
tinker-michaelj,
Neeharika-Sompalli and
Nana-EC
|
Kudos, SonarCloud Quality Gate passed!
|
Neeharika-Sompalli
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Extended one of the tests to assert that EVM is correctly set via Contract Create.
Removed few rows of logic from
HapiGetContractInfobecause it was doing some checks twice.Related issue(s):
Fixes #5708
Notes for reviewer:
Checklist