Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

05574 d busy time metric #5798

Merged
merged 27 commits into from May 4, 2023
Merged

05574 d busy time metric #5798

merged 27 commits into from May 4, 2023

Conversation

lpetrovic05
Copy link
Member

closes #5574

@lpetrovic05
added custom reset
1b9a18e 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
added integer epoch time
c0c977a 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
combined accumulator
3a8f5ab 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
working with diagram example
a192fd6 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
expanded unit tests
ef92ab8 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
docs
af140e3 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 self-assigned this Mar 24, 2023
@lpetrovic05
Merge branch 'develop' into 05574-D-busy-time-metric
ca220d9 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

# Conflicts:
#	platform-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/IntegerPairAccumulator.java
#	platform-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/platform/DefaultIntegerPairAccumulator.java
@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited

Node: Unit Test Results

  1 339 files    1 339 suites   1h 28m 56s ⏱️
97 421 tests 97 413 ✔️ 8 💤 0 ❌
99 052 runs  99 044 ✔️ 8 💤 0 ❌

Results for commit 44293aa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited

Platform: JUnit Test Report

     503 files           1 errors  502 suites   30m 2s ⏱️
13 605 tests 13 568 ✔️ 37 💤 0 ❌
15 388 runs  15 351 ✔️ 37 💤 0 ❌

Results for commit 44293aa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited

Node: Integration Test Results

    3 files      3 suites   14m 58s ⏱️
151 tests 151 ✔️ 0 💤 0 ❌
152 runs  152 ✔️ 0 💤 0 ❌

Results for commit 44293aa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   17m 8s ⏱️
309 tests 309 ✔️ 0 💤 0 ❌
327 runs  327 ✔️ 0 💤 0 ❌

Results for commit 44293aa.

♻️ This comment has been updated with latest results.

@netopyr
Copy link
Contributor

netopyr commented Mar 24, 2023

I don't think that the API changes are going in the right direction. Will need more time to go through the code more thoroughly to understand how everything fits together.

@lpetrovic05
Copy link
Member Author

I don't think that the API changes are going in the right direction. Will need more time to go through the code more thoroughly to understand how everything fits together.

I think the API atm is not good, I'm just working with what I got. Unless there is someone who has time to deal with metrics right now, we will just have to live with what we have.

@lpetrovic05
spotless
1a1285c 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
test fixes
7811ae9 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
sonar
a92d7a1 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
s
0048380 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
javadocs
2eb994d 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spotless
93b10d5 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 marked this pull request as ready for review March 27, 2023 10:29
@lpetrovic05 lpetrovic05 requested review from a team as code owners March 27, 2023 10:29
@lpetrovic05
revert changes
ab3d496 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@codecov
Copy link

codecov bot commented Apr 5, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: +91.36 🎉

Comparison is base (efc2775) 0.00% compared to head (2fb9497) 91.36%.

❗ Current head 2fb9497 differs from pull request most recent head 44293aa. Consider uploading reports for the commit 44293aa to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #5798       +/-   ##
==============================================
+ Coverage           0   91.36%   +91.36%     
- Complexity         0    16962    +16962     
==============================================
  Files              0     1270     +1270     
  Lines              0    48486    +48486     
  Branches           0     4840     +4840     
==============================================
+ Hits               0    44301    +44301     
- Misses             0     3261     +3261     
- Partials           0      924      +924

see 1270 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lpetrovic05
pr comments
40e0f08 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spotless
26a0270 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
revert
2fb9497 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
netopyr
netopyr reviewed Apr 6, 2023
View reviewed changes
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/extensions/BusyTime.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/extensions/BusyTime.java Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/extensions/BusyTime.java Outdated Show resolved Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/extensions/BusyTime.java Show resolved Hide resolved
.../swirlds-common/src/main/java/com/swirlds/common/metrics/extensions/DefaultMetricConfig.java Outdated Show resolved Hide resolved
...orm-sdk/swirlds-common/src/main/java/com/swirlds/common/metrics/extensions/IntPairUtils.java Outdated Show resolved Hide resolved
netopyr
netopyr previously approved these changes Apr 6, 2023
View reviewed changes
@poulok poulok added this to the v0.39 milestone Apr 28, 2023
@lpetrovic05
move byte utils
78ffb8f 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
PR comment
3bf0291 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spotless
28be39d 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
netopyr
netopyr previously approved these changes May 3, 2023
View reviewed changes
@lpetrovic05
add log statement
8f9dd4e 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spotless
44293aa 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

16.8% 16.8% Coverage
0.0% 0.0% Duplication

@lpetrovic05 lpetrovic05 merged commit e22dceb into develop May 4, 2023
16 of 18 checks passed
@lpetrovic05 lpetrovic05 deleted the 05574-D-busy-time-metric branch May 4, 2023 10:16
mhess-swl pushed a commit that referenced this pull request May 4, 2023
@lpetrovic05 @cody-littley @mhess-swl
05574 d busy time metric (#5798)
2f56aa6 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Co-authored-by: Cody Littley <56973212+cody-littley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@netopyr netopyr netopyr left review comments

@hendrikebbers hendrikebbers Awaiting requested review from hendrikebbers

@poulok poulok Awaiting requested review from poulok

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds deepak-swirlds is a code owner automatically assigned from hashgraph/platform-data

@jasperpotts jasperpotts Awaiting requested review from jasperpotts jasperpotts was automatically assigned from hashgraph/platform-architects

@alittley alittley Awaiting requested review from alittley

Assignees

@lpetrovic05 lpetrovic05

Labels
None yet
Projects
None yet
Milestone
v0.39
Development

Successfully merging this pull request may close these issues.

Create metrics for tracking thread work and performance
6 participants
@lpetrovic05 @netopyr @cody-littley @poulok @alittley @edward-swirldslabs