Add more hollow finalization tests #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
dimitar-dinev
added
Test Development
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/crypto/HollowAccountFinalizationSuite.java
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
dimitar-dinev
requested review from
nickpoorman,
MiroslavGatsanoga,
tinker-michaelj,
Neeharika-Sompalli and
stoqnkpL
Neeharika-Sompalli
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
HollowAccountFinalizationSuite:INSUFFICIENT_BALANCEContractCallcalling the precompile, where the executed precompile function needs signature for the hollow account (and it is provided in theunusedFullPrefixSigs) does not finalize the hollow accountRelated issue(s):
Fixes #5917
Notes for reviewer:
Checklist