Remove SessionContext #5974
Merged
Remove SessionContext #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
netopyr
added
CI:UnitTests
Modularization
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #5974 +/- ##
==============================================
+ Coverage 68.14% 91.36% +23.21%
+ Complexity 21953 16967 -4986
==============================================
Files 1960 1272 -688
Lines 133554 48479 -85075
Branches 7519 4839 -2680
==============================================
- Hits 91013 44291 -46722
+ Misses 41079 3266 -37813
+ Partials 1462 922 -540
... and 921 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
hendrikebbers
previously approved these changes
Apr 5, 2023
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
# Conflicts: # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/query/QueryCheckerTest.java # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/query/QueryWorkflowImplTest.java
|
SonarCloud Quality Gate failed. |
hendrikebbers
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
SessionContextas it is not needed right now. (We may have to add it later again, we will see.)Closes #5973