Revert to v0.35.3 ContractKey.hashCode()
#6012
Conversation
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6012 +/- ##
==============================================
+ Coverage 68.14% 91.36% +23.21%
+ Complexity 21953 16970 -4983
==============================================
Files 1960 1273 -687
Lines 133554 48501 -85053
Branches 7519 4839 -2680
==============================================
- Hits 91013 44313 -46700
+ Misses 41079 3266 -37813
+ Partials 1462 922 -540
... and 921 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
SonarCloud Quality Gate failed. |
| ^ x6) | ||
| ^ x7) | ||
| ^ x8); | ||
| } |
There was a problem hiding this comment.
odd choice by spotless, but one that works!
| @@ -133,7 +132,7 @@ public boolean equals(final Object o) { | |||
| /** Special hash to make sure we get good distribution. */ | |||
There was a problem hiding this comment.
How about, until the PR which is going to provide a custom-named persistent hash function for ContractKey lands, you enhance this javadoc with scary-sounding threats to intimidate anyone away from using this for some other persistent use than the one we're currently suffering from?
| val generatedSources = file("build/generated/sources/annotationProcessor/java/main") | ||
|
|
||
| java.sourceSets["main"].java.srcDir(generatedSources) | ||
|
|
There was a problem hiding this comment.
I don't get why this is in this PR. What's going on here?
There was a problem hiding this comment.
Avoids some annoying compile errors when the Gradle build doesn't grasp that sources have changed.
Description:
ContractKey.hashCode()implementation with some test vectors created using thev0.35.3tag.mono-servicesource set to avoid some build annoyances.