6077 - if no state is loaded, always use config address book. #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed use of genesis state supplier from AddressBookInitializer.java - updated code and unit tests to always use config address book when state is not loaded. Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6079 +/- ##
==========================================
Coverage ? 91.35%
Complexity ? 17028
==========================================
Files ? 1277
Lines ? 48672
Branches ? 4865
==========================================
Hits ? 44462
Misses ? 3280
Partials ? 930 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Please update the Notion Page documentation to reflect the behavior change implemented in this ticket. |
poulok
approved these changes
Apr 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
alittley
approved these changes
Apr 13, 2023
|
Kudos, SonarCloud Quality Gate passed! |
edward-swirldslabs
deleted the
6077-d-no-loaded-state-use-config-address-book-always
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #6077
Checklist