#5380 Introduced MappedConfigSource #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help transition from old config files to new config framework Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Help transition from old config files to new config framework Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
… into 05380-D-Configuration_Remapping
* Just logging for duplicate property and property not found Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Help transition from old config files to new config framework Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Help transition from old config files to new config framework Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
* Just logging for duplicate property and property not found Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
… into 05380-D-Configuration_Remapping
timo0
requested review from
edward-swirldslabs,
hendrikebbers,
artemananiev and
OlegMazurov
hendrikebbers
previously approved these changes
Apr 20, 2023
...k/swirlds-common/src/test/java/com/swirlds/common/config/sources/MappedConfigSourceTest.java
Show resolved
Hide resolved
...m-sdk/swirlds-common/src/main/java/com/swirlds/common/config/sources/MappedConfigSource.java
Show resolved
Hide resolved
platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/Browser.java
Outdated
Show resolved
Hide resolved
edward-swirldslabs
previously approved these changes
Apr 20, 2023
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
timo0
dismissed stale reviews from edward-swirldslabs and hendrikebbers
via
adc8d94
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
edward-swirldslabs
previously approved these changes
Apr 21, 2023
artemananiev
previously approved these changes
Apr 21, 2023
hendrikebbers
previously approved these changes
Apr 24, 2023
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
timo0
dismissed stale reviews from hendrikebbers, artemananiev, and edward-swirldslabs
via
2e7c759
edward-swirldslabs
approved these changes
Apr 25, 2023
OlegMazurov
approved these changes
Apr 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
jsync-swirlds
approved these changes
Apr 27, 2023
hendrikebbers
approved these changes
Apr 27, 2023
|
Kudos, SonarCloud Quality Gate passed! |
artemananiev
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5380
Difference to old: