ConfigConverter and ConfigSource implementations for the service layer #6107
+1,952
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
hendrikebbers
requested review from
mattp-swirldslabs,
nathanklick,
nickpoorman and
netopyr
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6107 +/- ##
==============================================
+ Coverage 0 91.08% +91.08%
- Complexity 0 16947 +16947
==============================================
Files 0 1295 +1295
Lines 0 48590 +48590
Branches 0 4905 +4905
==============================================
+ Hits 0 44257 +44257
- Misses 0 3396 +3396
- Partials 0 937 +937
... and 1279 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
netopyr
previously approved these changes
Apr 21, 2023
...edera-app-spi/src/main/java/com/hedera/node/app/spi/config/converter/AccountIDConverter.java
Show resolved
Hide resolved
...e/hedera-app-spi/src/main/java/com/hedera/node/app/spi/config/converter/FileIDConverter.java
Show resolved
Hide resolved
...spi/src/main/java/com/hedera/node/app/spi/config/converter/HederaFunctionalityConverter.java
Show resolved
Hide resolved
.../hedera-app-spi/src/main/java/com/hedera/node/app/spi/config/converter/ProfileConverter.java
Show resolved
Hide resolved
.../src/test/java/com/hedera/node/app/spi/config/converter/AbstractEnumConfigConverterTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/hedera/node/app/spi/config/converter/HederaFunctionalityConverterTest.java
Outdated
Show resolved
Hide resolved
...app-spi/src/test/java/com/hedera/node/app/spi/config/converter/SidecarTypeConverterTest.java
Outdated
Show resolved
Hide resolved
...a-app/src/main/java/com/hedera/node/app/config/converter/CongestionMultipliersConverter.java
Show resolved
Hide resolved
...-spi/src/main/java/com/hedera/node/app/spi/config/converter/AbstractEnumConfigConverter.java
Show resolved
Hide resolved
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
nathanklick
reviewed
Apr 21, 2023
|
@nathanklick looks like this was only a temporary issues that happened after the last update of the branch. |
netopyr
previously approved these changes
Apr 24, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
|
SonarCloud Quality Gate failed. |
netopyr
approved these changes
Apr 25, 2023
mhess-swl
approved these changes
Apr 27, 2023
rbair23
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the Config API in the service layer we need to provide converters for all types that the Config API should support nativ. This PR adds converters for all types and a config source that wraps a
PropertySourcePart of #5995