05875 query workflow improvements part3 #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
netopyr
added
CI:UnitTests
Modularization
netopyr
requested review from
nickpoorman,
hendrikebbers,
jasperpotts and
rbair23
rbair23
previously approved these changes
Apr 17, 2023
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
hendrikebbers
previously approved these changes
Apr 19, 2023
...service/src/main/java/com/hedera/node/app/service/mono/queries/validation/QueryFeeCheck.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/MonoQueryFeeCheck.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/MonoQueryFeeCheck.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/MonoQueryFeeCheck.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/fees/QueryFeeCheck.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6108 +/- ##
==============================================
+ Coverage 0 91.06% +91.06%
- Complexity 0 16896 +16896
==============================================
Files 0 1280 +1280
Lines 0 48489 +48489
Branches 0 4890 +4890
==============================================
+ Hits 0 44156 +44156
- Misses 0 3406 +3406
- Partials 0 927 +927
... and 1271 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
hendrikebbers
previously approved these changes
Apr 20, 2023
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/ingest/IngestWorkflowImpl.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/query/QueryWorkflowImpl.java
hendrikebbers
previously approved these changes
Apr 24, 2023
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
|
SonarCloud Quality Gate failed. |
mhess-swl
approved these changes
Apr 27, 2023
rbair23
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next and hopefully final part of changes that improve query and ingest workflow
QueryFeeCheckCounterfromIngestWorkflowImpl