Implement CryptoCreate handle method
#6112
Merged
+1,357
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
…otobuf Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
...-node/hapi-fees/src/main/java/com/hedera/node/app/hapi/fees/usage/crypto/CryptoOpsUsage.java
Outdated
Show resolved
Hide resolved
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAccountStore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
mhess-swl
reviewed
May 1, 2023
...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAccountStore.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/CryptoCreateHandler.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/CryptoCreateHandler.java
Show resolved
Hide resolved
...-node/hapi-fees/src/main/java/com/hedera/node/app/hapi/fees/usage/crypto/CryptoOpsUsage.java
Outdated
Show resolved
Hide resolved
.../test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoCreateHandlerTest.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
previously approved these changes
May 1, 2023
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
mhess-swl
approved these changes
May 3, 2023
tinker-michaelj
approved these changes
May 4, 2023
jeromy-cannon
approved these changes
May 4, 2023
mhess-swl
approved these changes
May 4, 2023
|
SonarCloud Quality Gate failed. |
mhess-swl
added a commit
that referenced
this pull request
May 4, 2023
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> # Conflicts: # hedera-node/hedera-token-service-impl/src/test/java/module-info.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6038
Fixes #6113
Depends on hashgraph/hedera-protobufs#270 these protobuf changes
WritableAccountStoreCryptoCreatehandle implementationpureChecksmethod to validate only transaction body fields that doesn't involve dynamic properties or state