Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

05365 Debuggable State Reference Counts #6142

Merged
merged 48 commits into from Apr 28, 2023
Merged

05365 Debuggable State Reference Counts #6142

merged 48 commits into from Apr 28, 2023

Conversation

cody-littley
Copy link
Contributor

@cody-littley cody-littley commented Apr 18, 2023 •
edited by poulok

Closes #5365

Breaking changes:

  • removed setting signedStateSentinelEnabled
  • Platform.getLatestImmutableState() and Platform. getLatestSignedState() now require a string description of why the state is being gotten

@cody-littley
Copy files from branch.
f796711 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental progress.
8d3f722 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Finish fixing SignedStateManager.java
e118a53 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Now compiling.
ca0ddc7 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Resolved some TODOs.
39c9a75 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix funky line wraps.
2c88943 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 05365-ref-count-debug
f914d11 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix TODO, write rules for signed state use.
ee84aca 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Incremental fixes.
2f5732d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.39 milestone Apr 18, 2023
@cody-littley cody-littley self-assigned this Apr 18, 2023
@cody-littley
Fixed NPEs.
c402504 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Improve log output for refcount leak.
96af4ea 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix bugs.
280024e 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited

Node: Unit Test Results

  1 337 files    1 337 suites   1h 12m 12s ⏱️
97 407 tests 97 399 ✔️ 8 💤 0 ❌
99 039 runs  99 031 ✔️ 8 💤 0 ❌

Results for commit 11460f3.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (develop@6609451). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head b8c6c53 differs from pull request most recent head 11460f3. Consider uploading reports for the commit 11460f3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #6142   +/-   ##
==========================================
  Coverage           ?   91.11%           
  Complexity         ?    17053           
==========================================
  Files              ?     1294           
  Lines              ?    48967           
  Branches           ?     4910           
==========================================
  Hits               ?    44614           
  Misses             ?     3422           
  Partials           ?      931

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited

Node: E2E Test Results

    1 files      1 suites   17m 7s ⏱️
309 tests 309 ✔️ 0 💤 0 ❌
327 runs  327 ✔️ 0 💤 0 ❌

Results for commit 11460f3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited

Node: Integration Test Results

    3 files      3 suites   14m 43s ⏱️
151 tests 151 ✔️ 0 💤 0 ❌
152 runs  152 ✔️ 0 💤 0 ❌

Results for commit 11460f3.

♻️ This comment has been updated with latest results.

@cody-littley
Improve refcount deboug output.
e9f89f6 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Better exception message if state is released too many times.
3c86928 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Misc bugfixes.
b03ed27 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Start debugging tests.
e2471e2 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed unit tests.
e31fa30 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fix more unit tests.
8214e0d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Checkpoint.
dbd1e03 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Create test context more efficiently.
15f1e37 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed more tests.
b6c951f 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Spotless
413c486 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Add reason for when a signed state is created.
b667d7d 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 05365-ref-count-debug-2
3a544cc 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Made suggested changes.
b121d23 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@poulok poulok changed the title 05365 ref count debug 2 05365 Debuggable State Reference Counts Apr 27, 2023
@cody-littley
Fixed broken unit test.
e2856fe 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed state editor.
e4ea938 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Merge branch 'develop' into 05365-ref-count-debug-2
798dc96 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley
Fixed unit test.
b8c6c53 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
poulok
poulok previously approved these changes Apr 28, 2023
View reviewed changes
@cody-littley
Merge branch 'develop' into 05365-ref-count-debug-2
cde623b 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley dismissed stale reviews from hendrikebbers and poulok via cde623b April 28, 2023 15:13
@cody-littley
spotless
11460f3 
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@poulok poulok mentioned this pull request Apr 28, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

51.3% 51.3% Coverage
0.0% 0.0% Duplication

@cody-littley cody-littley merged commit d7896bc into develop Apr 28, 2023
16 of 18 checks passed
@cody-littley cody-littley deleted the 05365-ref-count-debug-2 branch April 28, 2023 16:07
@kimbor kimbor mentioned this pull request Apr 28, 2023
Closed
@poulok poulok mentioned this pull request Apr 28, 2023
Closed
@kimbor kimbor mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulok poulok poulok approved these changes

@imalygin imalygin imalygin approved these changes

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@hendrikebbers hendrikebbers hendrikebbers left review comments

@lpetrovic05 lpetrovic05 Awaiting requested review from lpetrovic05 lpetrovic05 is a code owner automatically assigned from hashgraph/platform-hashgraph

@qnswirlds qnswirlds Awaiting requested review from qnswirlds qnswirlds is a code owner automatically assigned from hashgraph/release-engineering

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds deepak-swirlds is a code owner automatically assigned from hashgraph/platform-data

@OlegMazurov OlegMazurov Awaiting requested review from OlegMazurov OlegMazurov is a code owner automatically assigned from hashgraph/platform-architects

@netopyr netopyr Awaiting requested review from netopyr netopyr is a code owner automatically assigned from hashgraph/platform-base

@alittley alittley Awaiting requested review from alittley

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
v0.38
Development

Successfully merging this pull request may close these issues.

Debuggable State Reference Counts
5 participants
@cody-littley @poulok @imalygin @hendrikebbers @edward-swirldslabs