Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ownerId in synthetic child createApproveAllowanceForAllNFT txn #6177

Merged
merged 4 commits into from Apr 20, 2023

Conversation

mustafauzunn
Copy link
Collaborator

@mustafauzunn mustafauzunn commented Apr 19, 2023

Description:

  • Sets msg.sender as ownerId in synthetic createApproveAllowanceForAllNFT txn.

Related issue(s):

Fixes #6135

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn requested a review from a team as a code owner April 19, 2023 12:49
@mustafauzunn mustafauzunn self-assigned this Apr 19, 2023
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added Limechain Work planned for the LimeChain team CI:UnitTests labels Apr 19, 2023
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Node: Unit Test Results

  1 311 files    1 311 suites   1h 19m 33s ⏱️
97 114 tests 97 107 ✔️ 7 💤 0
98 756 runs  98 749 ✔️ 7 💤 0

Results for commit 0a26331.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +23.10 🎉

Comparison is base (935b992) 67.99% compared to head (be0779b) 91.09%.

❗ Current head be0779b differs from pull request most recent head 0a26331. Consider uploading reports for the commit 0a26331 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6177       +/-   ##
==============================================
+ Coverage      67.99%   91.09%   +23.10%     
+ Complexity     21901    16898     -5003     
==============================================
  Files           1966     1279      -687     
  Lines         133963    48478    -85485     
  Branches        7571     4890     -2681     
==============================================
- Hits           91084    44161    -46923     
+ Misses         41408     3390    -38018     
+ Partials        1471      927      -544     
Impacted Files Coverage Δ
...tore/contracts/precompile/SyntheticTxnFactory.java 99.76% <100.00%> (+<0.01%) ⬆️
...s/precompile/impl/SetApprovalForAllPrecompile.java 98.18% <100.00%> (+0.03%) ⬆️

... and 921 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Node: E2E Test Results

    1 files      1 suites   16m 43s ⏱️
307 tests 307 ✔️ 0 💤 0
325 runs  325 ✔️ 0 💤 0

Results for commit 0a26331.

♻️ This comment has been updated with latest results.

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Node: Integration Test Results

    3 files      3 suites   14m 49s ⏱️
150 tests 150 ✔️ 0 💤 0
151 runs  151 ✔️ 0 💤 0

Results for commit 0a26331.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoqnkpL stoqnkpL merged commit c94fc28 into develop Apr 20, 2023
10 of 11 checks passed
@stoqnkpL stoqnkpL deleted the 06135-fix-setApprovallForAll-set-owner branch April 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract precompile setApprovalForAll owner is not in transaction record
3 participants