New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dagger module for token service #6249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
netopyr
reviewed
Apr 25, 2023
...rvice-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenComponent.java
Show resolved
Hide resolved
...rvice-impl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenComponent.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandlersModule.java
Outdated
Show resolved
Hide resolved
...rvice-impl/src/test/java/com/hedera/node/app/service/token/impl/test/TokenComponentTest.java
Outdated
Show resolved
Hide resolved
hendrikebbers
requested review from
a team,
mhess-swl and
Neeharika-Sompalli
as code owners
April 25, 2023 14:47
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
SonarCloud Quality Gate failed. |
Neeharika-Sompalli
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! As Michael H said some javadocs might not be needed
qnswirlds
approved these changes
Apr 25, 2023
Will remove Javadoc with next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token service now has a dagger module. Same work should be done for all services once this PR is approved.