Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagger module for token service #6249

Merged
merged 6 commits into from Apr 26, 2023
Merged

Dagger module for token service #6249

merged 6 commits into from Apr 26, 2023

Conversation

hendrikebbers
Copy link
Member

@hendrikebbers hendrikebbers commented Apr 25, 2023

The token service now has a dagger module. Same work should be done for all services once this PR is approved.

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

Node: Unit Test Results

  1 317 files    1 317 suites   1h 21m 9s ⏱️
97 181 tests 97 174 ✔️ 7 💤 0
98 823 runs  98 816 ✔️ 7 💤 0

Results for commit a04321d.

♻️ This comment has been updated with latest results.

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

Node: Integration Test Results

    3 files      3 suites   14m 37s ⏱️
150 tests 150 ✔️ 0 💤 0
151 runs  151 ✔️ 0 💤 0

Results for commit a04321d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 25, 2023

Node: E2E Test Results

    1 files      1 suites   17m 10s ⏱️
309 tests 309 ✔️ 0 💤 0
327 runs  327 ✔️ 0 💤 0

Results for commit a04321d.

♻️ This comment has been updated with latest results.

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers hendrikebbers marked this pull request as ready for review April 25, 2023 14:47
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! As Michael H said some javadocs might not be needed

@hendrikebbers hendrikebbers merged commit dded517 into develop Apr 26, 2023
9 of 11 checks passed
@hendrikebbers hendrikebbers deleted the di-refactoring-token branch April 26, 2023 08:59
@hendrikebbers
Copy link
Member Author

Will remove Javadoc with next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants