New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added system startup diagram. #6269
Conversation
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Sweet! Do you want to check in the diagram "source" too? (So that if the diagram needs to be altered later, it'll be there.) |
The neat thing about this is that this |
Why are these boxes green?
It would helpful for each box to list the method being invoked so that it is very clear to application developers what is happening when. Most already have it, but not all. Lastly, see my comment on the ticket #5853 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Some thoughts
- Instead of "External stuff" you could note "External processes e.g JVM, network IO"
- In a later PR down the line it might be nice to have a section in the wiki that gives a brief summary of all the yellow and green boxes
Signed-off-by: Cody Littley <cody@swirldslabs.com>
db2481e
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
Closes #5853