Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppTestBase use simple config #6275

Merged
merged 1 commit into from Apr 28, 2023
Merged

AppTestBase use simple config #6275

merged 1 commit into from Apr 28, 2023

Conversation

hendrikebbers
Copy link
Member

Instead of using the test config and doing a full class scan the AppTestBase class use a basic config that only knows about the metrics config.

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Node: Unit Test Results

  1 317 files    1 317 suites   1h 12m 50s ⏱️
97 180 tests 97 173 ✔️ 7 💤 0
98 822 runs  98 815 ✔️ 7 💤 0

Results for commit d313309.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +23.27 🎉

Comparison is base (b9b192f) 67.82% compared to head (d313309) 91.10%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6275       +/-   ##
==============================================
+ Coverage      67.82%   91.10%   +23.27%     
+ Complexity     22043    17037     -5006     
==============================================
  Files           1985     1294      -691     
  Lines         134856    48891    -85965     
  Branches        7582     4902     -2680     
==============================================
- Hits           91469    44543    -46926     
+ Misses         41917     3420    -38497     
+ Partials        1470      928      -542     

see 925 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Node: Integration Test Results

    3 files      3 suites   14m 54s ⏱️
150 tests 150 ✔️ 0 💤 0
151 runs  151 ✔️ 0 💤 0

Results for commit d313309.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Node: E2E Test Results

    1 files      1 suites   17m 7s ⏱️
309 tests 309 ✔️ 0 💤 0
327 runs  327 ✔️ 0 💤 0

Results for commit d313309.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hendrikebbers hendrikebbers marked this pull request as ready for review April 27, 2023 12:08
@hendrikebbers hendrikebbers requested review from a team as code owners April 27, 2023 12:08
@hendrikebbers hendrikebbers merged commit e6743c7 into develop Apr 28, 2023
23 of 27 checks passed
@hendrikebbers hendrikebbers deleted the simple-metric-config branch April 28, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants