Call getNumberOfChildren() less in iterator. #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <cody@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
timo0
approved these changes
Apr 27, 2023
OlegMazurov
approved these changes
Apr 27, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6278
Emergency mitigation for performance issue noticed by Oleg where calling
parent.getNumberOfChildren()ends up being very expensive due to the way Java does inheritance and virtual methods.This is not a full fix, but will reduce the number of times this method is called to 1/4th its previous number (for binary trees).