New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require signing keys when doing event stream recovery. #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <cody@swirldslabs.com>
cody-littley
requested review from
lpetrovic05,
artemananiev,
timo0 and
jasperpotts
April 27, 2023 18:31
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #6285 +/- ##
==============================================
+ Coverage 67.82% 91.10% +23.27%
+ Complexity 22041 17036 -5005
==============================================
Files 1985 1294 -691
Lines 134861 48896 -85965
Branches 7582 4902 -2680
==============================================
- Hits 91470 44546 -46924
+ Misses 41919 3421 -38498
+ Partials 1472 929 -543 ☔ View full report in Codecov by Sentry. |
alittley
previously approved these changes
Apr 27, 2023
...lds-platform-core/src/main/java/com/swirlds/platform/recovery/internal/RecoveryPlatform.java
Show resolved
Hide resolved
...swirlds-platform-core/src/main/java/com/swirlds/platform/recovery/EventRecoveryWorkflow.java
Show resolved
Hide resolved
Signed-off-by: Cody Littley <cody@swirldslabs.com>
alittley
approved these changes
Apr 27, 2023
artemananiev
approved these changes
Apr 27, 2023
Kudos, SonarCloud Quality Gate passed! |
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6284