Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require signing keys when doing event stream recovery. #6285

Merged
merged 3 commits into from Apr 27, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #6284

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Node: Unit Test Results

  1 318 files    1 318 suites   1h 16m 45s ⏱️
97 180 tests 97 173 ✔️ 7 💤 0
98 822 runs  98 815 ✔️ 7 💤 0

Results for commit 247c46a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +23.27 🎉

Comparison is base (6fdc9dd) 67.82% compared to head (247c46a) 91.10%.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6285       +/-   ##
==============================================
+ Coverage      67.82%   91.10%   +23.27%     
+ Complexity     22041    17036     -5005     
==============================================
  Files           1985     1294      -691     
  Lines         134861    48896    -85965     
  Branches        7582     4902     -2680     
==============================================
- Hits           91470    44546    -46924     
+ Misses         41919     3421    -38498     
+ Partials        1472      929      -543     

see 925 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Node: E2E Test Results

    1 files      1 suites   17m 5s ⏱️
309 tests 309 ✔️ 0 💤 0
327 runs  327 ✔️ 0 💤 0

Results for commit 247c46a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Node: Integration Test Results

    3 files      3 suites   15m 12s ⏱️
150 tests 150 ✔️ 0 💤 0
151 runs  151 ✔️ 0 💤 0

Results for commit 247c46a.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Platform: JUnit Test Report

     499 files           1 errors  498 suites   26m 50s ⏱️
13 573 tests 13 532 ✔️ 41 💤 0
15 356 runs  15 315 ✔️ 41 💤 0

Results for commit 247c46a.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cody-littley cody-littley merged commit ec0701e into develop Apr 27, 2023
18 of 20 checks passed
@cody-littley cody-littley deleted the 06284-es-recovery-fix branch April 27, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make keys optional for event stream recovery
3 participants