Distinguish auto-approvals in synthetic CryptoTransfer transfer lists
#6290
+622
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Nana-EC
requested review from
Neeharika-Sompalli,
lukelee-sl and
david-bakin-sl
Nana-EC
added
the
Hedera Smart Contract Service
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Nana-EC
reviewed
Apr 27, 2023
...m/hedera/node/app/service/mono/store/contracts/precompile/impl/SynthApprovalRecordsTest.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/hedera/services/bdd/spec/utilops/streams/assertions/IdScreenedAssertion.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6290 +/- ##
==============================================
+ Coverage 0 91.11% +91.11%
- Complexity 0 17069 +17069
==============================================
Files 0 1294 +1294
Lines 0 49012 +49012
Branches 0 4918 +4918
==============================================
+ Hits 0 44656 +44656
- Misses 0 3424 +3424
- Partials 0 932 +932
☔ View full report in Codecov by Sentry. |
lukelee-sl
reviewed
Apr 27, 2023
...ava/com/hedera/node/app/service/mono/store/contracts/precompile/impl/TransferPrecompile.java
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Nana-EC
previously approved these changes
Apr 28, 2023
...ava/com/hedera/node/app/service/mono/store/contracts/precompile/impl/TransferPrecompile.java
Show resolved
Hide resolved
...ava/com/hedera/node/app/service/mono/store/contracts/precompile/impl/TransferPrecompile.java
Show resolved
Hide resolved
...ava/com/hedera/node/app/service/mono/store/contracts/precompile/impl/TransferPrecompile.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
tinker-michaelj
dismissed stale reviews from Neeharika-Sompalli and Nana-EC
via
1427c43
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Neeharika-Sompalli
approved these changes
Apr 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TransferPrecompileto produce a syntheticCryptoTransferTransactionBodywithis_approval = truefor each asset change that was automatically switched to use an approval/allowance.RecordStreamAssertionimplementation.