New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a PCLI sub command to sign services stream files #6309
Conversation
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
…mand Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6309 +/- ##
==============================================
+ Coverage 0 90.89% +90.89%
- Complexity 0 17413 +17413
==============================================
Files 0 1343 +1343
Lines 0 50126 +50126
Branches 0 5024 +5024
==============================================
+ Hits 0 45561 +45561
- Misses 0 3604 +3604
- Partials 0 961 +961
☔ View full report in Codecov by Sentry. |
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
hedera-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamSignCommand.java
Outdated
Show resolved
Hide resolved
.../cli-clients/src/main/java/com/hedera/services/cli/sign/InvalidProtobufVersionException.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
...li-clients/src/test/java/com.hedera.services.cli.sign.test/RecordStreamSigningUtilsTest.java
Show resolved
Hide resolved
Is a test to compare generated signature files with the original signature files ? Input is record/balance file with original signature file (obtained test net) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Following my standard practice - all comments are for information only, or suggestions that are up to you to judge. No bugs or other required changes that I need.
hedera-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamSignCommand.java
Show resolved
Hide resolved
hedera-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamType.java
Show resolved
Hide resolved
...i-clients/src/test/java/com.hedera.services.cli.sign.test/AccountBalanceSignCommandTest.java
Outdated
Show resolved
Hide resolved
...i-clients/src/test/java/com.hedera.services.cli.sign.test/AccountBalanceSignCommandTest.java
Show resolved
Hide resolved
...-clients/src/test/java/com.hedera.services.cli.sign.test/AccountBalanceSigningUtilsTest.java
Outdated
Show resolved
Hide resolved
...ra-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamSigningUtils.java
Show resolved
Hide resolved
...ra-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamSigningUtils.java
Outdated
Show resolved
Hide resolved
...ra-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamSigningUtils.java
Show resolved
Hide resolved
...ra-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamSigningUtils.java
Show resolved
Hide resolved
...-clients/src/test/java/com.hedera.services.cli.sign.test/AccountBalanceSigningUtilsTest.java
Show resolved
Hide resolved
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
...ra-node/cli-clients/src/main/java/com/hedera/services/cli/sign/RecordStreamSigningUtils.java
Show resolved
Hide resolved
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with respect to the Gradle and module changes only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with respect to the Gradle and module changes only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Related issue(s):
Fixes #5710
Adds unit tests for #6264
To run pcli command as:
pcli record-stream sign keyFile keyFilePassword keyAlias -d=signedRecordStream -p=toBeSignedRecordStream -hv 0.37.0-allowance-SNAPSHOT
pcli -h, pcli record-stream sign -h, pcli account-balance sign -h to see the help messages
Notes for reviewer:
Checklist