Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move token revoke verification method to preHandle #6318

Merged
merged 3 commits into from May 2, 2023

Conversation

mhess-swl
Copy link
Member

No description provided.

Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl added CI:FinalChecks Modularization Issues or PRs related to modularization labels Apr 28, 2023
@mhess-swl mhess-swl added this to the v0.39 milestone Apr 28, 2023
@mhess-swl mhess-swl self-assigned this Apr 28, 2023
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Node: Unit Test Results

  1 338 files    1 338 suites   1h 29m 9s ⏱️
97 418 tests 97 410 ✔️ 8 💤 0
99 049 runs  99 041 ✔️ 8 💤 0

Results for commit bfbd19f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +23.14 🎉

Comparison is base (5d90093) 67.86% compared to head (2deb60b) 91.00%.

❗ Current head 2deb60b differs from pull request most recent head bfbd19f. Consider uploading reports for the commit bfbd19f to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #6318       +/-   ##
==============================================
+ Coverage      67.86%   91.00%   +23.14%     
+ Complexity     22170    17156     -5014     
==============================================
  Files           2005     1312      -693     
  Lines         135357    49321    -86036     
  Branches        7637     4949     -2688     
==============================================
- Hits           91854    44883    -46971     
+ Misses         42011     3490    -38521     
+ Partials        1492      948      -544     
Impacted Files Coverage Δ
...mpl/handlers/TokenRevokeKycFromAccountHandler.java 100.00% <100.00%> (ø)

... and 927 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Node: E2E Test Results

    1 files      1 suites   17m 7s ⏱️
309 tests 309 ✔️ 0 💤 0
327 runs  327 ✔️ 0 💤 0

Results for commit bfbd19f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Node: Integration Test Results

    3 files      3 suites   15m 21s ⏱️
151 tests 151 ✔️ 0 💤 0
152 runs  152 ✔️ 0 💤 0

Results for commit bfbd19f.

♻️ This comment has been updated with latest results.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on naming, otherwise LGTM !

Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented May 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mhess-swl mhess-swl merged commit 0b73223 into develop May 2, 2023
10 of 11 checks passed
@mhess-swl mhess-swl deleted the 05912_move-prechecks branch May 2, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Modularization Issues or PRs related to modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants