06302 - turn NodeId into a record containing a long #6370
Merged
+308
−437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
# Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/components/EventCreator.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/creation/ChatterEventCreator.java # platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/state/SwirldStateManagerImplTests.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
# Conflicts: # platform-sdk/platform-apps/tests/PlatformTestingTool/src/test/java/com/swirlds/demo/platform/FCMQueryControllerTest.java
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #6370 +/- ##
===============================
===============================
☔ View full report in Codecov by Sentry. |
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
# Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
hendrikebbers
previously approved these changes
May 10, 2023
...-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/TransactionPool.java
Outdated
Show resolved
Hide resolved
# Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/SwirldsPlatform.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
alittley
reviewed
May 11, 2023
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/system/NodeId.java
Outdated
Show resolved
Hide resolved
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/system/NodeId.java
Outdated
Show resolved
Hide resolved
...mon/swirlds-common-test/src/main/java/com/swirlds/common/test/stream/StreamObjectWorker.java
Outdated
Show resolved
Hide resolved
...mmon/swirlds-common-test/src/test/java/com/swirlds/common/test/stream/TestStreamManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
hendrikebbers
previously approved these changes
May 12, 2023
alittley
previously approved these changes
May 12, 2023
...form-test/src/test/java/com/swirlds/platform/test/network/OutboundConnectionManagerTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/PlatformMetrics.java # platform-sdk/swirlds-unit-tests/core/swirlds-platform-test/src/test/java/com/swirlds/platform/test/components/EventMapperTest.java
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
edward-swirldslabs
dismissed stale reviews from alittley and hendrikebbers
via
7e6cb76
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
alittley
approved these changes
May 12, 2023
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
isMirror()related attributes from NodeIdEventCreationRulefrom NodeIdgetIdAsInt()equals(long id)tomatches(long id)create()with a static concurrent hashmap from Long to NodeId to minimize construction of the record.Related issue(s):
Fixes #6302
Notes for reviewer:
Removing the hashcode implementation causes the app to misbehave, so it is left in.