Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only com.swirlds is scanned by ConfigurationHolder #6430

Merged
merged 1 commit into from May 5, 2023
Merged

Only com.swirlds is scanned by ConfigurationHolder #6430

merged 1 commit into from May 5, 2023
+3 −1

Conversation

hendrikebbers
Copy link
Member

Fixes #6429

@hendrikebbers
Only com.swirlds is scanned by ConfigurationHolder
cacf1d8 
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers hendrikebbers self-assigned this May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Node: Unit Test Results

  1 339 files    1 339 suites   1h 28m 47s ⏱️
97 421 tests 97 413 ✔️ 8 💤 0 ❌
99 052 runs  99 044 ✔️ 8 💤 0 ❌

Results for commit cacf1d8.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented May 4, 2023

Node: Integration Test Results

    3 files      3 suites   14m 58s ⏱️
151 tests 151 ✔️ 0 💤 0 ❌
152 runs  152 ✔️ 0 💤 0 ❌

Results for commit cacf1d8.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Node: E2E Test Results

    1 files      1 suites   17m 8s ⏱️
309 tests 309 ✔️ 0 💤 0 ❌
327 runs  327 ✔️ 0 💤 0 ❌

Results for commit cacf1d8.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Platform: JUnit Test Report

     503 files           1 errors  502 suites   19m 56s ⏱️
13 605 tests 13 568 ✔️ 37 💤 0 ❌
15 388 runs  15 351 ✔️ 37 💤 0 ❌

Results for commit cacf1d8.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hendrikebbers hendrikebbers marked this pull request as ready for review May 4, 2023 14:34
@hendrikebbers hendrikebbers requested review from a team as code owners May 4, 2023 14:34
@hendrikebbers hendrikebbers merged commit 43caff5 into develop May 5, 2023
26 of 31 checks passed
@hendrikebbers hendrikebbers deleted the 6429-d-scan-only-swirlds branch May 5, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemananiev artemananiev artemananiev approved these changes

@poulok poulok Awaiting requested review from poulok poulok is a code owner automatically assigned from hashgraph/platform-hashgraph

@netopyr netopyr Awaiting requested review from netopyr netopyr is a code owner automatically assigned from hashgraph/platform-base

Assignees

@hendrikebbers hendrikebbers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config API: static ConfigurationHolder breaks usage in services
2 participants
@hendrikebbers @artemananiev