Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lay groundwork for ignoring app transactions during pces replay. #6442

Merged
merged 2 commits into from May 4, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #6437

When we replay the preconsensus event stream, we don't want to be accepting application transactions. This PR lays the groundwork for that.

Also included in this PR is some light cleanup that I did along the way as I did my investigation for this task.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented May 4, 2023

Node: Unit Test Results

  1 339 files    1 339 suites   1h 28m 47s ⏱️
97 421 tests 97 413 ✔️ 8 💤 0
99 052 runs  99 044 ✔️ 8 💤 0

Results for commit 4fcb8ca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Node: E2E Test Results

    1 files      1 suites   17m 8s ⏱️
309 tests 309 ✔️ 0 💤 0
327 runs  327 ✔️ 0 💤 0

Results for commit 4fcb8ca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Node: Integration Test Results

    3 files      3 suites   14m 58s ⏱️
151 tests 151 ✔️ 0 💤 0
152 runs  152 ✔️ 0 💤 0

Results for commit 4fcb8ca.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cody-littley cody-littley added this to the v0.39 milestone May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Platform: JUnit Test Report

     506 files           1 errors  505 suites   20m 47s ⏱️
13 639 tests 13 602 ✔️ 37 💤 0
15 423 runs  15 386 ✔️ 37 💤 0

Results for commit 4fcb8ca.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@cody-littley cody-littley merged commit 5243bb7 into develop May 4, 2023
16 of 18 checks passed
@cody-littley cody-littley deleted the 06437-pces-no-app-txns branch May 4, 2023 19:23
mhess-swl pushed a commit that referenced this pull request May 4, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not accept application transactions during PCES replay
2 participants